Skip to content

Fix docs formatting issues. #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix docs formatting issues. #4147

merged 1 commit into from
Dec 2, 2020

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Dec 1, 2020

Some @link tags were incorrectly formatted or the generated html file had the wrong case, leading to broken links in generated docs.

Sort of hard to avoid in Node docs, because comments sometimes reference some pages that only exist in (client) JS docs. Decided to remove the markup and leave the words as plain text in this case.

Also added 2 missing TOC entries from Storage.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2020

⚠️ No Changeset found

Latest commit: 0050338

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 requested a review from egilmorez December 1, 2020 19:46
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Christina! One question for you.

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (b87cfd1) and head commit (de064a5).

Test Logs

@hsubox76 hsubox76 merged commit daea032 into master Dec 2, 2020
@firebase firebase locked and limited conversation to collaborators Jan 2, 2021
@hsubox76 hsubox76 deleted the ch-docfix branch January 21, 2021 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants