Skip to content

Fix remote-config-exp installations import #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

hsubox76
Copy link
Contributor

If this import is not in the same file that uses the code (that has the getProvider() call), this import gets tree-shaken out during the rollup build and installations fails to register. (The error won't happen if there's another library, like performance, bringing in installations.)

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2020

⚠️ No Changeset found

Latest commit: 125b551

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (44b5251) and head commit (25ee5a9).

Test Logs

Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but I'm not sure getProvider() decides whether or not the import is tree shaken because it's a side effect import and I don't think rollup is capable of knowing whether things in @firebase/installations-exp is used or not in the importing module.

Actually I think import @firebase/installations-exp should always be removed regardless of its location because we set moduleSideEffect: true in the rollup config. It may be a bug in rollup, or something I don't fully understand. For now, the PR is good to go to unblock the releases.

@hsubox76 hsubox76 merged commit 08aa4b1 into master Dec 11, 2020
@firebase firebase locked and limited conversation to collaborators Jan 11, 2021
@hsubox76 hsubox76 deleted the ch-inst-exp-fix branch January 21, 2021 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants