Skip to content

remove side effect imports in exp build #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

Feiyang1
Copy link
Member

Remove import '@firebase/app-types'; from the bundle

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2021

⚠️ No Changeset found

Latest commit: d8e1adb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 merged commit 09470fe into master Jan 22, 2021
@Feiyang1 Feiyang1 deleted the fei-databaseexp-fix branch January 22, 2021 00:31
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (d42bb39) and head commit (ec5b7d1).

@firebase firebase locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants