Skip to content

Fix analytics-types-exp import and fix exp release script #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Fix analytics-types-exp import and fix exp release script #4325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a733260
Fix commitAndPush
hsubox76 Jan 21, 2021
3072f56
Fix analytics
hsubox76 Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages-exp/analytics-exp/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
ControlParams,
EventParams,
MinimalDynamicConfig
} from '@firebase/analytics-types';
} from '@firebase/analytics-types-exp';
import { GtagCommand, GTAG_URL } from './constants';
import { logger } from './logger';

Expand Down
4 changes: 2 additions & 2 deletions scripts/exp/release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ async function publishExpPackages({ dryRun }: { dryRun: boolean }) {
const { shouldCommitAndPush } = await prompt([
{
type: 'confirm',
name: 'commitAndPush',
name: 'shouldCommitAndPush',
message:
'Do you want to commit and push the exp version update to remote?',
default: true
Expand Down Expand Up @@ -438,7 +438,7 @@ async function updatePackageJsons(
}

async function commitAndPush(versions: Map<string, string>) {
await exec('git add */package.json yarn.lock');
await exec('git add packages-exp/firebase-exp/package.json yarn.lock');

const firebaseExpVersion = versions.get(FIREBASE_UMBRELLA_PACKAGE_NAME);
await exec(
Expand Down