Skip to content

Add storage-types to exp release script #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 22, 2021
Merged

Add storage-types to exp release script #4331

merged 4 commits into from
Jan 22, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 22, 2021 •
edited
Loading

Ensure exp version of storage-types is properly packaged with other exp packages.
Tested with --dry-run release.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 50f7ca5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 22, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (5221904) and head commit (db75503).

@hsubox76 hsubox76 changed the title Change storage-types dep version Add storage-types to exp release script Jan 22, 2021
@hsubox76 hsubox76 merged commit 94681d9 into master Jan 22, 2021
@hsubox76 hsubox76 deleted the ch-expfix4 branch January 22, 2021 23:37
@firebase firebase locked and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1