Skip to content

Removing RxFire #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Removing RxFire #4332

merged 3 commits into from
Jun 18, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Jan 22, 2021

We've decided to move RxFire to it's own repo, firebaseextended/rxfire.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2021

⚠️ No Changeset found

Latest commit: 3f5c699

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (5221904) and head commit (2c26e16).

@jamesdaniels jamesdaniels marked this pull request as ready for review January 24, 2021 03:18
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty thorough, thanks!

@Feiyang1
Copy link
Member

Feiyang1 commented Feb 2, 2021

@jamesdaniels Is it ready to be merged?

@jamesdaniels
Copy link
Member Author

@Feiyang1 not yet, I need to get approval for the launch. Will ping you when we're green.

@jamesdaniels
Copy link
Member Author

@Feiyang1 new repo is up and running. We're good to merge this.

@Feiyang1
Copy link
Member

Feiyang1 commented Mar 9, 2021

@jamesdaniels Awesome! would you mind fixing the conflict?

@jamesdaniels
Copy link
Member Author

Will do. I think it's just the package.json changed whereas I deleted it.

@Feiyang1 Feiyang1 merged commit e689ff6 into master Jun 18, 2021
@Feiyang1 Feiyang1 deleted the removing_rxfire branch June 18, 2021 18:11
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (f037995) Head (b7500bd) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)
  • @firebase/api-documenter

    Type Base (f037995) Head (b7500bd) Diff
    main ? 3.72 kB ? (?)
  • @firebase/app

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 11.0 kB ? (?)
    esm2017 ? 9.81 kB ? (?)
    lite ? 8.95 kB ? (?)
    lite-esm2017 ? 7.93 kB ? (?)
    main ? 10.2 kB ? (?)
    module ? 11.0 kB ? (?)
    react-native ? 9.87 kB ? (?)
  • @firebase/app-check

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 20.9 kB ? (?)
    esm2017 ? 17.3 kB ? (?)
    main ? 20.9 kB ? (?)
    module ? 20.5 kB ? (?)
  • @firebase/auth

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)
  • @firebase/component

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 8.33 kB ? (?)
    esm2017 ? 6.32 kB ? (?)
    main ? 8.67 kB ? (?)
    module ? 8.33 kB ? (?)
  • @firebase/database

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 296 kB ? (?)
    esm2017 ? 265 kB ? (?)
    main ? 299 kB ? (?)
    module ? 296 kB ? (?)
  • @firebase/database-compat

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 86.5 kB ? (?)
    main ? 103 kB ? (?)
    module ? 86.5 kB ? (?)
  • @firebase/database-exp

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 246 kB ? (?)
    main ? 278 kB ? (?)
    module ? 246 kB ? (?)
  • @firebase/firestore

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 284 kB ? (?)
    esm2017 ? 226 kB ? (?)
    main ? 531 kB ? (?)
    module ? 284 kB ? (?)
    react-native ? 227 kB ? (?)
  • @firebase/firestore-compat

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 28.9 kB ? (?)
    main ? 38.1 kB ? (?)
    module ? 28.9 kB ? (?)
    react-native ? 28.7 kB ? (?)
  • @firebase/firestore-exp

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 224 kB ? (?)
    main ? 510 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 224 kB ? (?)
  • @firebase/firestore-lite

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 72.5 kB ? (?)
    main ? 149 kB ? (?)
    module ? 72.5 kB ? (?)
    react-native ? 72.7 kB ? (?)
  • @firebase/firestore/bundle

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 290 kB ? (?)
    esm2017 ? 177 kB ? (?)
    main ? 527 kB ? (?)
    module ? 290 kB ? (?)
    react-native ? 177 kB ? (?)
  • @firebase/firestore/memory

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 216 kB ? (?)
    esm2017 ? 172 kB ? (?)
    main ? 325 kB ? (?)
    module ? 216 kB ? (?)
    react-native ? 172 kB ? (?)
  • @firebase/firestore/memory-bundle

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 224 kB ? (?)
    esm2017 ? 177 kB ? (?)
    main ? 322 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 177 kB ? (?)
  • @firebase/functions

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 10.7 kB ? (?)
    esm2017 ? 8.21 kB ? (?)
    main ? 11.1 kB ? (?)
    module ? 10.7 kB ? (?)
  • @firebase/installations

    Type Base (f037995) Head (b7500bd) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)
  • @firebase/logger

    Type Base (f037995) Head (b7500bd) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)
  • @firebase/messaging

    Type Base (f037995) Head (b7500bd) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)
  • @firebase/performance

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)
  • @firebase/polyfill

    Type Base (f037995) Head (b7500bd) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)
  • @firebase/remote-config

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)
  • @firebase/rules-unit-testing

    Type Base (f037995) Head (b7500bd) Diff
    main ? 14.8 kB ? (?)
  • @firebase/storage

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 63.4 kB ? (?)
    esm2017 ? 54.6 kB ? (?)
    main ? 63.8 kB ? (?)
    module ? 63.4 kB ? (?)
  • @firebase/storage-compat

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 10.2 kB ? (?)
    main ? 29.1 kB ? (?)
    module ? 10.2 kB ? (?)
  • @firebase/storage-exp

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 51.5 kB ? (?)
    main ? 52.6 kB ? (?)
    module ? 51.5 kB ? (?)
  • @firebase/util

    Type Base (f037995) Head (b7500bd) Diff
    browser ? 21.2 kB ? (?)
    esm2017 ? 20.0 kB ? (?)
    main ? 25.8 kB ? (?)
    module ? 21.2 kB ? (?)
  • @firebase/webchannel-wrapper

    Type Base (f037995) Head (b7500bd) Diff
    esm2017 ? 43.2 kB ? (?)
    main ? 50.7 kB ? (?)
    module ? 44.6 kB ? (?)
  • firebase

    Click to show 16 binary size changes.
    Type Base (f037995) Head (b7500bd) Diff
    firebase-analytics.js ? 35.7 kB ? (?)
    firebase-app-check.js ? 22.2 kB ? (?)
    firebase-app.js ? 21.9 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 187 kB ? (?)
    firebase-firestore.js ? 336 kB ? (?)
    firebase-firestore.memory.js ? 271 kB ? (?)
    firebase-functions.js ? 10.9 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 40.9 kB ? (?)
    firebase-performance-standalone.es2017.js ? 73.4 kB ? (?)
    firebase-performance-standalone.js ? 49.8 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 41.5 kB ? (?)
    firebase.js ? 892 kB ? (?)

Test Logs

@firebase firebase locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants