-
Notifications
You must be signed in to change notification settings - Fork 944
Removing RxFire #4332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing RxFire #4332
Conversation
|
Size Analysis Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty thorough, thanks!
@jamesdaniels Is it ready to be merged? |
@Feiyang1 not yet, I need to get approval for the launch. Will ping you when we're green. |
@Feiyang1 new repo is up and running. We're good to merge this. |
@jamesdaniels Awesome! would you mind fixing the conflict? |
Will do. I think it's just the package.json changed whereas I deleted it. |
Binary Size ReportAffected SDKs
Test Logs |
We've decided to move RxFire to it's own repo, firebaseextended/rxfire.