Skip to content

Remove Prototype-Patching in Repo_transaction #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2021
Merged

Remove Prototype-Patching in Repo_transaction #4345

merged 3 commits into from
Jan 26, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

This should allow us to build the SDK without relying on module side-effects.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3cd0f50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/removeprototypepatching branch 3 times, most recently from e952745 to bec2f81 Compare January 26, 2021 19:02
@schmidt-sebastian
Remove Prototype-Patching in Repo-transaction
3795525 
This should allow us to build the SDK without relying on module side-effects
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/removeprototypepatching branch from bec2f81 to 3795525 Compare January 26, 2021 19:03
@schmidt-sebastian schmidt-sebastian changed the title Remove Prototype-Patching in Repo-transaction Remove Prototype-Patching in Repo_transaction Jan 26, 2021
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (c2bd3db) and head commit (d3e6b1a).

Feiyang1
Feiyang1 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird we wrote it this way before.

@schmidt-sebastian
Copy link
Contributor Author

Thanks for helping me notice that CI finally passed :)

@schmidt-sebastian schmidt-sebastian merged commit 269c918 into master Jan 26, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/removeprototypepatching branch January 26, 2021 23:38
@firebase firebase locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @Feiyang1