Skip to content

Fix bug in rtdb query get test #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Fix bug in rtdb query get test #4366

merged 1 commit into from
Jan 29, 2021

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Jan 29, 2021

Before this test was trying to shallow-compare the promise object to {foo: 'bar'}.

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2021

⚠️ No Changeset found

Latest commit: dde3a8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (4986a3e) and head commit (9beded9).

@jmwski jmwski merged commit 31f8bd5 into master Jan 29, 2021
@jmwski jmwski deleted the jw/fix-get-warning branch January 29, 2021 21:20
@firebase firebase locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants