Skip to content

Check changesets to make sure firebase main package bumps are included #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 3, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 2, 2021

Check for highest bump in changeset, if it's minor or major, see if "firebase" is included, and if it's bumped high enough. Set to block if it fails (although this check hasn't been set to blocking in the github repo settings yet).

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2021

⚠️ No Changeset found

Latest commit: 278b8c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Co-authored-by: Feiyang <[email protected]>
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (6766da2) Head (990adf2) Diff
    esm2017 ? 18.6 kB ? (?)
    main ? 24.4 kB ? (?)
    module ? 23.3 kB ? (?)
  • @firebase/analytics-exp

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 22.2 kB ? (?)
    esm2017 ? 17.6 kB ? (?)
    main ? 23.1 kB ? (?)
    module ? 22.2 kB ? (?)
  • @firebase/app

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 11.2 kB ? (?)
    esm2017 ? 9.60 kB ? (?)
    lite ? 9.27 kB ? (?)
    lite-esm2017 ? 7.89 kB ? (?)
    main ? 11.0 kB ? (?)
    module ? 11.2 kB ? (?)
    react-native ? 10.7 kB ? (?)
  • @firebase/auth

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)
  • @firebase/component

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 5.18 kB ? (?)
    esm2017 ? 3.99 kB ? (?)
    main ? 5.90 kB ? (?)
    module ? 5.18 kB ? (?)
  • @firebase/database

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 276 kB ? (?)
    esm2017 ? 243 kB ? (?)
    main ? 279 kB ? (?)
    module ? 276 kB ? (?)
  • @firebase/database-exp

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 277 kB ? (?)
    esm2017 ? 241 kB ? (?)
    main ? 279 kB ? (?)
    module ? 277 kB ? (?)
  • @firebase/firestore

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 259 kB ? (?)
    esm2017 ? 201 kB ? (?)
    main ? 530 kB ? (?)
    module ? 259 kB ? (?)
    react-native ? 201 kB ? (?)
  • @firebase/firestore-exp

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 199 kB ? (?)
    main ? 505 kB ? (?)
    module ? 199 kB ? (?)
    react-native ? 199 kB ? (?)
  • @firebase/firestore-lite

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 64.7 kB ? (?)
    main ? 143 kB ? (?)
    module ? 64.7 kB ? (?)
    react-native ? 65.0 kB ? (?)
  • @firebase/firestore/bundle

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 266 kB ? (?)
    esm2017 ? 155 kB ? (?)
    main ? 526 kB ? (?)
    module ? 266 kB ? (?)
    react-native ? 155 kB ? (?)
  • @firebase/firestore/memory

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 196 kB ? (?)
    esm2017 ? 152 kB ? (?)
    main ? 324 kB ? (?)
    module ? 196 kB ? (?)
    react-native ? 152 kB ? (?)
  • @firebase/firestore/memory-bundle

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 204 kB ? (?)
    esm2017 ? 155 kB ? (?)
    main ? 321 kB ? (?)
    module ? 204 kB ? (?)
    react-native ? 155 kB ? (?)
  • @firebase/functions

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 9.87 kB ? (?)
    esm2017 ? 7.69 kB ? (?)
    main ? 10.3 kB ? (?)
    module ? 9.87 kB ? (?)
  • @firebase/installations

    Type Base (6766da2) Head (990adf2) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.7 kB ? (?)
    module ? 21.6 kB ? (?)
  • @firebase/logger

    Type Base (6766da2) Head (990adf2) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.75 kB ? (?)
    module ? 4.83 kB ? (?)
  • @firebase/messaging

    Type Base (6766da2) Head (990adf2) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)
  • @firebase/performance

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 27.6 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.5 kB ? (?)
    module ? 27.6 kB ? (?)
  • @firebase/polyfill

    Type Base (6766da2) Head (990adf2) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)
  • @firebase/remote-config

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.4 kB ? (?)
    module ? 22.4 kB ? (?)
  • @firebase/rules-unit-testing

    Type Base (6766da2) Head (990adf2) Diff
    main ? 12.2 kB ? (?)
  • @firebase/storage

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 60.2 kB ? (?)
    esm2017 ? 51.9 kB ? (?)
    main ? 61.2 kB ? (?)
    module ? 60.2 kB ? (?)
  • @firebase/storage/exp

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 49.1 kB ? (?)
    main ? 49.9 kB ? (?)
    module ? 49.1 kB ? (?)
  • @firebase/util

    Type Base (6766da2) Head (990adf2) Diff
    browser ? 20.2 kB ? (?)
    esm2017 ? 19.0 kB ? (?)
    main ? 22.1 kB ? (?)
    module ? 20.2 kB ? (?)
  • @firebase/webchannel-wrapper

    Type Base (6766da2) Head (990adf2) Diff
    esm2017 ? 39.5 kB ? (?)
    main ? 47.2 kB ? (?)
    module ? 40.8 kB ? (?)
  • firebase

    Click to show 15 binary size changes.
    Type Base (6766da2) Head (990adf2) Diff
    firebase-analytics.js ? 35.7 kB ? (?)
    firebase-app.js ? 20.1 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 195 kB ? (?)
    firebase-firestore.js ? 304 kB ? (?)
    firebase-firestore.memory.js ? 243 kB ? (?)
    firebase-functions.js ? 9.99 kB ? (?)
    firebase-installations.js ? 19.0 kB ? (?)
    firebase-messaging.js ? 40.8 kB ? (?)
    firebase-performance-standalone.es2017.js ? 71.8 kB ? (?)
    firebase-performance-standalone.js ? 48.3 kB ? (?)
    firebase-performance.js ? 38.5 kB ? (?)
    firebase-remote-config.js ? 36.8 kB ? (?)
    firebase-storage.js ? 39.8 kB ? (?)
    firebase.js ? 856 kB ? (?)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (6766da2) and head commit (990adf2) are too large (460,953 characters) to display.

Please check below links to see details from the original test log.

@hsubox76 hsubox76 merged commit a5ac818 into master Feb 3, 2021
@hsubox76 hsubox76 deleted the ch-check-firebase branch February 3, 2021 20:22
@firebase firebase locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants