Skip to content

Add initializePerformance() to performance-exp #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2021

⚠️ No Changeset found

Latest commit: d4e1bbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@jposuna jposuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these changes!

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/component

    Type Base (24b6d7d) Head (498a1f5) Diff
    browser 5.18 kB 5.33 kB +147 B (+2.8%)
    esm2017 3.99 kB 4.08 kB +83 B (+2.1%)
    main 5.90 kB 6.05 kB +147 B (+2.5%)
    module 5.18 kB 5.33 kB +147 B (+2.8%)
  • firebase

    Type Base (24b6d7d) Head (498a1f5) Diff
    firebase-app.js 20.1 kB 20.2 kB +86 B (+0.4%)
    firebase-database.js 194 kB 194 kB +88 B (+0.0%)
    firebase-performance-standalone.es2017.js 71.8 kB 71.9 kB +58 B (+0.1%)
    firebase-performance-standalone.js 48.2 kB 48.3 kB +86 B (+0.2%)
    firebase.js 855 kB 855 kB +88 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/app-exp

    • initializeApp

      Size Table

      TypeBase (24b6d7d)Head (498a1f5)Diff
      size-with-ext-deps
      9.19 kB
      9.24 kB
      +48 B (+0.5%)
  • @firebase/performance-exp

    • getPerformance

      Size Table

      TypeBase (24b6d7d)Head (498a1f5)Diff
      size
      17.3 kB
      17.3 kB
      +55 B (+0.3%)
      size-with-ext-deps
      34.5 kB
      34.5 kB
      +55 B (+0.2%)
    • initializePerformance

      Size Table

      TypeBase (24b6d7d)Head (498a1f5)Diff
      size
      ?
      17.4 kB
      ? (?)
      size-with-ext-deps
      ?
      34.6 kB
      ? (?)

      Dependency Table

      TypeBase (24b6d7d)Head (498a1f5)Diff
      functions
      ?

      50 dependencies

      addToQueue
      changeInitializationStatus
      configValid
      convertMetricValueToInteger
      createNetworkRequestEntry
      createUserTimingTrace
      dispatchQueueEvents
      getApiKey
      getAppId
      getApplicationInfo
      getAuthTokenPromise
      getConfig
      getDocumentReadyComplete
      getEffectiveConnectionType
      getIid
      getIidPromise
      getInitializationPromise
      getProjectId
      getRemoteConfig
      getServiceWorkerStatus
      getStoredConfig
      getVisibilityState
      initializePerf
      initializePerformance
      isPerfInitialized
      isValidCustomAttributeName
      isValidCustomAttributeValue
      isValidMetricName
      logNetworkRequest
      logTrace
      mergeStrings
      postToFlEndpoint
      processConfig
      processQueue
      registerPerformance
      sendEventsToFl
      sendLog
      sendTraceLog
      serializeNetworkRequest
      serializeTrace
      serializer
      setupApi
      setupNetworkRequests
      setupOobResources
      setupOobTraces
      setupTransportService
      setupUserTimingTraces
      shouldLogAfterSampling
      storeConfig
      transportHandler
      

      ?
      classes
      ?

      Api
      PerformanceController
      SettingsService
      Trace
      

      ?
      variables
      ?

      46 dependencies

      ATTRIBUTE_FORMAT_REGEX
      CONFIG_EXPIRY_LOCAL_STORAGE_KEY
      CONFIG_LOCAL_STORAGE_KEY
      COULD_NOT_GET_CONFIG_MSG
      DEFAULT_CONFIGS
      DEFAULT_ENTRY_NAME
      DEFAULT_REMAINING_TRIES
      DEFAULT_SEND_INTERVAL_MS
      ERROR_DESCRIPTION_MAP
      ERROR_FACTORY
      FID_WAIT_TIME_MS
      FIRST_CONTENTFUL_PAINT_COUNTER_NAME
      FIRST_INPUT_DELAY_COUNTER_NAME
      FIRST_PAINT_COUNTER_NAME
      FIS_AUTH_PREFIX
      INITIAL_SEND_TIME_DELAY_MS
      MAX_ATTRIBUTE_NAME_LENGTH
      MAX_ATTRIBUTE_VALUE_LENGTH
      MAX_EVENT_COUNT_PER_REQUEST
      MAX_METRIC_NAME_LENGTH
      OOB_TRACE_PAGE_LOAD_PREFIX
      REMOTE_CONFIG_SDK_VERSION
      RESERVED_ATTRIBUTE_PREFIXES
      RESERVED_AUTO_PREFIX
      SDK_VERSION
      SERVICE
      SERVICE_NAME
      TRACE_MEASURE_PREFIX
      TRACE_START_MARK_PREFIX
      TRACE_STOP_MARK_PREFIX
      VisibilityState
      apiInstance
      consoleLogger
      factory
      iid
      initializationPromise
      initializationStatus
      isTransportSetup
      logger
      name
      oobMetrics
      queue
      remainingTries
      settingsServiceInstance
      version
      windowInstance
      

      ?
      enums
      ?
      ?

      External Dependency Table

      ModuleBase (24b6d7d)Head (498a1f5)Diff
      @firebase/util
      ?

      ErrorFactory
      isIndexedDBAvailable
      validateIndexedDBOpenable
      

      ?
      @firebase/logger
      ?

      LogLevel
      Logger
      

      ?
      @firebase/app-exp
      ?

      _getProvider
      _registerComponent
      registerVersion
      

      ?
      @firebase/component
      ?

      Component
      

      ?
    • trace

      Size Table

      TypeBase (24b6d7d)Head (498a1f5)Diff
      size
      17.2 kB
      17.2 kB
      +68 B (+0.4%)
      size-with-ext-deps
      34.4 kB
      34.5 kB
      +68 B (+0.2%)

@Feiyang1 Feiyang1 merged commit 5c2669a into master Feb 11, 2021
@Feiyang1 Feiyang1 deleted the fei-perf-exp-init branch February 11, 2021 20:06
@firebase firebase locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants