Skip to content

Add remaining bits to support Cordova redirect sign in #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 16, 2021

Cordova can use the platform_browser redirect entry points entirely, we just need to add new functions that have a different return type (Promise<void> instead of Promise<never>)

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2021

⚠️ No Changeset found

Latest commit: 42d507c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (40afc0c) and head commit (9531608).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • linkWithRedirect

      Size Table

      TypeBase (40afc0c)Head (9531608)Diff
      size
      31.9 kB
      32.0 kB
      +36 B (+0.1%)
      size-with-ext-deps
      42.6 kB
      42.7 kB
      +36 B (+0.1%)

      Dependency Table

      TypeBase (40afc0c)Head (9531608)Diff
      functions

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      + _linkWithRedirect

    • reauthenticateWithRedirect

      Size Table

      TypeBase (40afc0c)Head (9531608)Diff
      size
      31.7 kB
      31.7 kB
      +36 B (+0.1%)
      size-with-ext-deps
      42.4 kB
      42.4 kB
      +36 B (+0.1%)

      Dependency Table

      TypeBase (40afc0c)Head (9531608)Diff
      functions

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      + _reauthenticateWithRedirect

    • signInWithRedirect

      Size Table

      TypeBase (40afc0c)Head (9531608)Diff
      size
      31.4 kB
      31.4 kB
      +36 B (+0.1%)
      size-with-ext-deps
      42.1 kB
      42.2 kB
      +36 B (+0.1%)

      Dependency Table

      TypeBase (40afc0c)Head (9531608)Diff
      functions

      50 dependencies

      _assert
      _castAuth
      _createError
      _emulatorUrl
      _fail
      _getBrowserName
      _getClientVersion
      _getCurrentScheme
      _getFinalTarget
      _getInstance
      _getUserLanguage
      _isAndroid
      _isBlackBerry
      _isChromeIOS
      _isFirefox
      _isHttpOrHttps
      _isIEMobile
      _isOnline
      _isSafari
      _isWebOS
      _logError
      _logoutIfInvalidated
      _parseToken
      _performApiRequest
      _performFetchWithErrorHandling
      _performSignInRequest
      _persistenceKeyName
      _prodErrorMap
      _reloadWithoutSaving
      _tokenExpiresIn
      _withDefaultResolver
      assertStringOrUndefined
      createErrorInternal
      debugAssert
      debugFail
      deleteAccount
      extractProviderData
      getAccountInfo
      getIdTokenResult
      getVersionForPlatform
      isUserInvalidated
      makeTaggedError
      mergeProviderData
      registerAuth
      reload
      requestStsToken
      secondsStringToMilliseconds
      signInWithIdp
      signInWithRedirect
      utcTimestampToDateString
      

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      + _signInWithRedirect

@sam-gc sam-gc merged commit ee6980d into master Feb 18, 2021
@sam-gc sam-gc deleted the samgho/cordova-redirect-complete branch February 18, 2021 19:14
@firebase firebase locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants