Skip to content

Add assertion for the presence of document to the recaptcha verifier #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2021
Merged

Add assertion for the presence of document to the recaptcha verifier #4483

merged 3 commits into from
Feb 17, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 17, 2021

This closes out b/166287960

@sam-gc sam-gc requested a review from yuchenshi February 17, 2021 18:28
@sam-gc sam-gc requested a review from avolkovi as a code owner February 17, 2021 18:28
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5ed8009

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 17, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (4ab5a9c) and head commit (fe37e01).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 17, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • RecaptchaVerifier

      Size Table

      TypeBase (4ab5a9c)Head (fe37e01)Diff
      size
      34.2 kB
      34.3 kB
      +89 B (+0.3%)
      size-with-ext-deps
      44.9 kB
      45.0 kB
      +90 B (+0.2%)

@sam-gc sam-gc merged commit c6eadf7 into master Feb 17, 2021
@sam-gc sam-gc deleted the samgho/recaptcha-dom branch February 17, 2021 20:26
@firebase firebase locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi