Refactor QueryParams #4485
Refactor QueryParams #4485
Conversation
|
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis Report |
| } | ||
|
|
||
| /** | ||
| * What does isDefault() mean? |
There was a problem hiding this comment.
Were you planning to get an answer before checking in the code?
There was a problem hiding this comment.
Removed the comment. But what does it mean @schmidt-sebastian ?
There was a problem hiding this comment.
It's a query with no filters and no constraints with the default ordering (by priority)
| if (this.endNameSet_) { | ||
| qs[REST_CONSTANTS.END_AT] += ',' + stringify(this.indexEndName_); | ||
| } | ||
| export function queryParamsGetQueryObject( |
There was a problem hiding this comment.
FYI It looks like you re-ordered some of the methods, which makes this a internals impossible to review. I trust that you updated the methods correctly.
| } | ||
|
|
||
| /** | ||
| * What does isDefault() mean? |
There was a problem hiding this comment.
It's a query with no filters and no constraints with the default ordering (by priority)
I kept simple getters and
copy()within the class. Other methods are changed to functions.