Skip to content

Remove messaging-types-exp #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 24, 2021
Merged

Remove messaging-types-exp #4498

merged 5 commits into from
Feb 24, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2021

⚠️ No Changeset found

Latest commit: ef61807

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (368f517) and head commit (aa3d5cb).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (368f517) and head commit (aa3d5cb).

zwu52
zwu52 approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@zwu52 zwu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hsubox76
hsubox76 approved these changes Feb 24, 2021
View reviewed changes
common/api-review/messaging-exp.api.md
@@ -25,7 +36,31 @@ export function getToken(messaging: FirebaseMessaging, options?: {
swReg?: ServiceWorkerRegistration;
}): Promise<string>;

export { MessagePayload }
// @public (undocumented)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these have documentation? It looks like they didn't previously.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should. @zwu52, can you please add missing comments for the public APIs. Let's do it in a separate PR though.

@Feiyang1 Feiyang1 merged commit d84e137 into master Feb 24, 2021
@Feiyang1 Feiyang1 deleted the fei-rm-messaging-types-exp branch February 24, 2021 22:39
@firebase firebase locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@zwu52 zwu52 zwu52 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@zwu52 zwu52

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @hsubox76 @zwu52