Skip to content

Remove performance-types-exp #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2021
Merged

Remove performance-types-exp #4500

merged 4 commits into from
Feb 25, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2021

⚠️ No Changeset found

Latest commit: d21ed7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 20, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (c632148) and head commit (c72cca5).

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 20, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (c632148) and head commit (c72cca5).

Test Logs

hsubox76
hsubox76 approved these changes Feb 25, 2021
View reviewed changes
common/api-review/performance-exp.api.md
// @public
export function initializePerformance(app: FirebaseApp, settings?: PerformanceSettings): FirebasePerformance;

// @public (undocumented)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add documentation comments, I guess in a follow-up PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alikn Can we add missing documentation in a separate PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@Feiyang1 Feiyang1 merged commit 89a4f64 into master Feb 25, 2021
@Feiyang1 Feiyang1 deleted the fei-rm-perf-types-exp branch February 25, 2021 01:30
@firebase firebase locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alikn alikn alikn approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@jposuna jposuna

@alikn alikn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Feiyang1 @google-oss-bot @alikn @hsubox76 @jposuna