Remove storage-types/exp #4507
Remove storage-types/exp #4507
Conversation
hsubox76
requested review from
Feiyang1,
hiranya911 and
schmidt-sebastian
as code owners
|
| } from '@firebase/storage-types/exp'; | ||
| FullMetadata, | ||
| UploadTaskSnapshot | ||
| } from './public-types'; |
There was a problem hiding this comment.
We can directly export them instead of import, then export since ./public-types is part of the project, so we won't have the typings in the js file issues.
There was a problem hiding this comment.
Also can we just export every thing from ./public-types. All types in ./public-types are supposed to be public/exported.
There was a problem hiding this comment.
Done. A number of these types are used in this file so I kept those imports.
packages/storage/package.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'", | |||
| "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'", | |||
| "build": "rollup -c rollup.config.compat.js && yarn build:exp", | |||
| "build:exp": "rollup -c rollup.config.exp.js ; yarn api-report", | |||
| "build:exp": "rollup -c rollup.config.exp.js && yarn api-report", | |||
There was a problem hiding this comment.
I think we want ; which executes regardless of the return status of the previous command. I believe rollup -c rollup.config.exp.js will return an error status in the exp release build, though build will go through.
Binary Size ReportAffected SDKsNo changes between base commit (145c62b) and head commit (8cb9427). Test Logs
|
Size Analysis Report |
Remove exp types for storage as part of the effort to remove all -types packages from the exp SDK.