Skip to content

Add protobuf license needed for internal use. #4509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

Add protobuf license needed for internal use. #4509

merged 2 commits into from
Mar 3, 2021

Conversation

hsubox76
Copy link
Contributor

See cl/358448976 (internal).

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: f0dfd10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (938dc1a) Head (647e9c1) Diff
    main 24.5 kB 24.2 kB -294 B (-1.2%)

  • @firebase/app

    Type Base (938dc1a) Head (647e9c1) Diff
    main 10.6 kB 9.93 kB -647 B (-6.1%)
    react-native 10.3 kB 9.64 kB -639 B (-6.2%)

  • @firebase/component

    Type Base (938dc1a) Head (647e9c1) Diff
    main 6.05 kB 5.63 kB -412 B (-6.8%)

  • @firebase/database

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 277 kB 274 kB -2.35 kB (-0.9%)
    esm2017 245 kB 246 kB +365 B (+0.1%)
    main 280 kB 277 kB -2.63 kB (-0.9%)
    module 277 kB 274 kB -2.35 kB (-0.9%)

  • @firebase/database-exp

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 278 kB 274 kB -3.29 kB (-1.2%)
    esm2017 243 kB 243 kB -514 B (-0.2%)
    main 279 kB 276 kB -3.71 kB (-1.3%)
    module 278 kB 274 kB -3.29 kB (-1.2%)

  • @firebase/firestore

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 259 kB 259 kB -111 B (-0.0%)
    esm2017 202 kB 201 kB -107 B (-0.1%)
    main 531 kB 530 kB -661 B (-0.1%)
    module 259 kB 259 kB -111 B (-0.0%)
    react-native 202 kB 201 kB -107 B (-0.1%)

  • @firebase/firestore-exp

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 199 kB 199 kB -107 B (-0.1%)
    main 505 kB 505 kB -434 B (-0.1%)
    module 199 kB 199 kB -107 B (-0.1%)
    react-native 200 kB 200 kB -107 B (-0.1%)

  • @firebase/firestore-lite

    Type Base (938dc1a) Head (647e9c1) Diff
    main 144 kB 143 kB -247 B (-0.2%)

  • @firebase/firestore/bundle

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 266 kB 266 kB -111 B (-0.0%)
    esm2017 155 kB 155 kB -107 B (-0.1%)
    main 527 kB 526 kB -687 B (-0.1%)
    module 266 kB 266 kB -111 B (-0.0%)
    react-native 155 kB 155 kB -107 B (-0.1%)

  • @firebase/firestore/memory

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 196 kB 196 kB -111 B (-0.1%)
    esm2017 152 kB 152 kB -107 B (-0.1%)
    main 324 kB 324 kB -649 B (-0.2%)
    module 196 kB 196 kB -111 B (-0.1%)
    react-native 152 kB 152 kB -107 B (-0.1%)

  • @firebase/firestore/memory-bundle

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 205 kB 204 kB -111 B (-0.1%)
    esm2017 155 kB 155 kB -107 B (-0.1%)
    main 321 kB 321 kB -687 B (-0.2%)
    module 205 kB 204 kB -111 B (-0.1%)
    react-native 155 kB 155 kB -107 B (-0.1%)

  • @firebase/installations

    Type Base (938dc1a) Head (647e9c1) Diff
    main 22.7 kB 22.2 kB -486 B (-2.1%)

  • @firebase/logger

    Type Base (938dc1a) Head (647e9c1) Diff
    main 5.75 kB 5.50 kB -247 B (-4.3%)

  • @firebase/performance

    Type Base (938dc1a) Head (647e9c1) Diff
    main 28.5 kB 28.0 kB -494 B (-1.7%)

  • @firebase/remote-config

    Type Base (938dc1a) Head (647e9c1) Diff
    main 23.4 kB 22.9 kB -490 B (-2.1%)

  • @firebase/rules-unit-testing

    Type Base (938dc1a) Head (647e9c1) Diff
    main 12.2 kB 12.5 kB +302 B (+2.5%)

  • @firebase/storage

    Type Base (938dc1a) Head (647e9c1) Diff
    main 61.2 kB 60.7 kB -510 B (-0.8%)

  • @firebase/storage/exp

    Type Base (938dc1a) Head (647e9c1) Diff
    main 49.9 kB 50.0 kB +33 B (+0.1%)

  • @firebase/util

    Type Base (938dc1a) Head (647e9c1) Diff
    browser 20.2 kB 20.5 kB +285 B (+1.4%)
    esm2017 19.0 kB 19.2 kB +275 B (+1.4%)
    main 22.1 kB 24.8 kB +2.63 kB (+11.9%)
    module 20.2 kB 20.5 kB +285 B (+1.4%)

  • @firebase/webchannel-wrapper

    Type Base (938dc1a) Head (647e9c1) Diff
    main 47.2 kB 46.9 kB -247 B (-0.5%)

  • firebase

    Type Base (938dc1a) Head (647e9c1) Diff
    firebase-database.js 189 kB 184 kB -5.83 kB (-3.1%)
    firebase-firestore.js 304 kB 303 kB -117 B (-0.0%)
    firebase-firestore.memory.js 243 kB 243 kB -117 B (-0.0%)
    firebase.js 851 kB 845 kB -6.12 kB (-0.7%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (938dc1a) and head commit (647e9c1) are too large (172,764 characters) to display.

Please check below links to see details from the original test log.

Feiyang1
Feiyang1 reviewed Feb 23, 2021
View reviewed changes
LICENSE Outdated

For Google protobuf source.

file: src/packages/firestore/src/protos/google/protobuf/any.proto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the path here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a relative path in google3, it's copied verbatim from the CL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this license is for the public version of the SDK, should it use the path in Github?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we want to write a special script to reformat it on google3 import, it's probably best to make it applicable to wherever it is. I tried

[source code root]/packages/firestore/src/protos/google/protobuf/any.proto

Feiyang1
Feiyang1 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update a script to change the path for google3?

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Mar 2, 2021
@hsubox76
Copy link
Contributor Author

hsubox76 commented Mar 3, 2021

Discussed with CL author, the path does not need to be strict, it is just for providing context to any human readers of the license.

@hsubox76 hsubox76 merged commit b63d84d into master Mar 3, 2021
@hsubox76 hsubox76 deleted the ch-license branch March 3, 2021 20:04
@firebase firebase locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1