Skip to content

Reference doc generator for devsite #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 10, 2021
Merged

Reference doc generator for devsite #4517

merged 22 commits into from
Mar 10, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (ec95df3) Head (337c7cf) Diff
    browser 275 kB 275 kB -7 B (-0.0%)
    esm2017 248 kB 248 kB +156 B (+0.1%)
    main 277 kB 277 kB -7 B (-0.0%)
    module 275 kB 275 kB -7 B (-0.0%)

  • @firebase/database-exp

    Type Base (ec95df3) Head (337c7cf) Diff
    browser 272 kB 272 kB -7 B (-0.0%)
    esm2017 245 kB 245 kB +156 B (+0.1%)
    main 273 kB 273 kB -7 B (-0.0%)
    module 272 kB 272 kB -7 B (-0.0%)

  • firebase

    Click to show 12 binary size changes.
    Type Base (ec95df3) Head (337c7cf) Diff
    firebase-analytics.js 35.6 kB 35.6 kB -6 B (-0.0%)
    firebase-auth.js 177 kB 177 kB -14 B (-0.0%)
    firebase-database.js 179 kB 178 kB -608 B (-0.3%)
    firebase-firestore.js 303 kB 303 kB -10 B (-0.0%)
    firebase-firestore.memory.js 243 kB 243 kB -10 B (-0.0%)
    firebase-functions.js 10.1 kB 10.1 kB -1 B (-0.0%)
    firebase-installations.js 19.1 kB 19.1 kB -1 B (-0.0%)
    firebase-messaging.js 40.8 kB 40.8 kB -1 B (-0.0%)
    firebase-performance.js 38.2 kB 38.2 kB -1 B (-0.0%)
    firebase-remote-config.js 36.7 kB 36.7 kB -1 B (-0.0%)
    firebase-storage.js 39.8 kB 39.8 kB -1 B (-0.0%)
    firebase.js 839 kB 839 kB -638 B (-0.1%)

Test Logs

Feiyang1
Feiyang1 commented Feb 24, 2021
View reviewed changes
repo-scripts/api-documenter/src/cli/ApiDocumenterCommandLine.ts
* limitations under the License.
*/

// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samtstern This is a fork of https://github.com/microsoft/rushstack/tree/master/apps/api-documenter
What should we do about the license?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (ec95df3) and head commit (337c7cf).

@Feiyang1 Feiyang1 changed the title [WIP] Reference doc generator for devsite Reference doc generator for devsite Feb 25, 2021
hsubox76
hsubox76 approved these changes Feb 25, 2021
View reviewed changes
repo-scripts/api-documenter/src/documenters/MarkdownDocumenter.ts Outdated
});
}

console.log();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Removed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 166476f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 merged commit 44759f7 into master Mar 10, 2021
@Feiyang1 Feiyang1 deleted the fei-documenter branch March 10, 2021 19:15
@firebase firebase locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @hsubox76