Skip to content

Update @rollup/plugin-node-resolve #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2021
Merged

Update @rollup/plugin-node-resolve #4518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d91b0a3
Update dependency @rollup/plugin-node-resolve to v11
renovate-bot Feb 23, 2021
fd40cd2
Upgrade @rollup/plugin-node-resolve
hsubox76 Feb 24, 2021
8295c4a
Revert extra files
hsubox76 Feb 24, 2021
5d7f555
Remove api-review commits
hsubox76 Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages-exp/analytics-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"rollup": "2.33.2",
"@rollup/plugin-commonjs": "17.1.0",
"@rollup/plugin-json": "4.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-typescript2": "0.29.0",
"typescript": "4.0.5"
},
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/auth-compat-exp/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"rollup-plugin-replace": "2.2.0",
"@rollup/plugin-commonjs": "17.1.0",
"rollup-plugin-license": "0.14.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-sourcemaps": "0.6.3",
"rollup-plugin-typescript2": "0.29.0",
"rollup-plugin-uglify": "6.0.4",
Expand Down
20 changes: 14 additions & 6 deletions packages-exp/auth-compat-exp/demo/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,17 +942,17 @@
dependencies:
"@rollup/pluginutils" "^3.0.8"

"@rollup/plugin-node-resolve@9.0.0":
version "9.0.0"
resolved "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-9.0.0.tgz#39bd0034ce9126b39c1699695f440b4b7d2b62e6"
integrity sha512-gPz+utFHLRrd41WMP13Jq5mqqzHL3OXrfj3/MkSyB6UBIcuNt9j60GCbarzMzdf1VHFpOxfQh/ez7wyadLMqkg==
"@rollup/plugin-node-resolve@11.2.0":
version "11.2.0"
resolved "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-11.2.0.tgz#a5ab88c35bb7622d115f44984dee305112b6f714"
integrity sha512-qHjNIKYt5pCcn+5RUBQxK8krhRvf1HnyVgUCcFFcweDS7fhkOLZeYh0mhHK6Ery8/bb9tvN/ubPzmfF0qjDCTA==
dependencies:
"@rollup/pluginutils" "^3.1.0"
"@types/resolve" "1.17.1"
builtin-modules "^3.1.0"
deepmerge "^4.2.2"
is-module "^1.0.0"
resolve "^1.17.0"
resolve "^1.19.0"

"@rollup/pluginutils@^3.0.8", "@rollup/pluginutils@^3.0.9", "@rollup/pluginutils@^3.1.0":
version "3.1.0"
Expand Down Expand Up @@ -2737,7 +2737,7 @@ is-ci@^2.0.0:
dependencies:
ci-info "^2.0.0"

is-core-module@^2.1.0:
is-core-module@^2.1.0, is-core-module@^2.2.0:
version "2.2.0"
resolved "https://registry.npmjs.org/is-core-module/-/is-core-module-2.2.0.tgz#97037ef3d52224d85163f5597b2b63d9afed981a"
integrity sha512-XRAfAdyyY5F5cOXn7hYQDqh2Xmii+DEfIcQGxK/uNwMHhIkPWO0g8msXcbzLe+MpGoR951MlqM/2iIlU4vKDdQ==
Expand Down Expand Up @@ -4445,6 +4445,14 @@ resolve@^1.10.0, resolve@^1.17.0:
is-core-module "^2.1.0"
path-parse "^1.0.6"

resolve@^1.19.0:
version "1.20.0"
resolved "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz#629a013fb3f70755d6f0b7935cc1c2c5378b1975"
integrity sha512-wENBPt4ySzg4ybFQW2TT1zMQucPK95HSh/nq2CFTZVOGut2+pQvSsgtda4d26YrYcr067wjbmzOG8byDPBX63A==
dependencies:
is-core-module "^2.2.0"
path-parse "^1.0.6"

restore-cursor@^2.0.0:
version "2.0.0"
resolved "https://registry.npmjs.org/restore-cursor/-/restore-cursor-2.0.0.tgz#9f7ee287f82fd326d4fd162923d62129eee0dfaf"
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/auth-exp/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"rollup-plugin-terser": "6.1.0",
"rollup-plugin-typescript2": "0.29.0",
"rollup-plugin-uglify": "6.0.4",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"lerna": "3.22.1"
},
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/firebase-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"rollup": "2.35.1",
"@rollup/plugin-commonjs": "17.1.0",
"rollup-plugin-license": "2.2.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-sourcemaps": "0.6.3",
"rollup-plugin-terser": "7.0.2",
"rollup-plugin-typescript2": "0.29.0",
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/installations-compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"rollup": "2.33.2",
"@rollup/plugin-commonjs": "17.1.0",
"@rollup/plugin-json": "4.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-typescript2": "0.29.0",
"rollup-plugin-uglify": "6.0.4",
"typescript": "4.0.5"
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/installations-exp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"rollup": "2.35.1",
"@rollup/plugin-commonjs": "17.1.0",
"@rollup/plugin-json": "4.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-typescript2": "0.29.0",
"rollup-plugin-uglify": "6.0.4",
"typescript": "4.0.5"
Expand Down
2 changes: 1 addition & 1 deletion packages/analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"rollup": "2.35.1",
"@rollup/plugin-commonjs": "17.1.0",
"@rollup/plugin-json": "4.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-typescript2": "0.29.0",
"typescript": "4.0.5"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"rollup": "2.35.1",
"@rollup/plugin-commonjs": "17.1.0",
"rollup-plugin-license": "2.2.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-sourcemaps": "0.6.3",
"rollup-plugin-terser": "7.0.2",
"rollup-plugin-typescript2": "0.29.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"@firebase/app": "0.6.15",
"@rollup/plugin-alias": "3.1.1",
"@rollup/plugin-json": "4.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"@types/eslint": "7.2.6",
"@types/json-stable-stringify": "1.0.32",
"json-stable-stringify": "1.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/installations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"rollup": "2.35.1",
"@rollup/plugin-commonjs": "17.1.0",
"@rollup/plugin-json": "4.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-typescript2": "0.29.0",
"rollup-plugin-uglify": "6.0.4",
"typescript": "4.0.5"
Expand Down
2 changes: 1 addition & 1 deletion packages/rxfire/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"firebase": "8.2.9",
"rollup": "2.35.1",
"@rollup/plugin-commonjs": "17.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-typescript2": "0.29.0",
"rollup-plugin-uglify": "6.0.4",
"typescript": "4.0.5"
Expand Down
4 changes: 1 addition & 3 deletions repo-scripts/size-analysis/bundle/rollup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ export async function bundleWithRollup(
};

if (moduleDirectory) {
resolveOptions.customResolveOptions = {
moduleDirectory
};
resolveOptions.moduleDirectories = [moduleDirectory];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! How did you catch the problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it errors if you try to run it with the upgraded plugin, so I checked the changelog for breaking changes and this was there.

}

const bundle = await rollup.rollup({
Expand Down
2 changes: 1 addition & 1 deletion repo-scripts/size-analysis/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"rollup": "2.35.1",
"@rollup/plugin-commonjs": "17.1.0",
"@rollup/plugin-json": "4.1.0",
"@rollup/plugin-node-resolve": "9.0.0",
"@rollup/plugin-node-resolve": "11.2.0",
"rollup-plugin-replace": "2.2.0",
"rollup-plugin-typescript2": "0.29.0",
"@rollup/plugin-virtual": "2.0.3",
Expand Down
20 changes: 14 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2359,17 +2359,17 @@
dependencies:
"@rollup/pluginutils" "^3.0.8"

"@rollup/plugin-node-resolve@9.0.0":
version "9.0.0"
resolved "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-9.0.0.tgz#39bd0034ce9126b39c1699695f440b4b7d2b62e6"
integrity sha512-gPz+utFHLRrd41WMP13Jq5mqqzHL3OXrfj3/MkSyB6UBIcuNt9j60GCbarzMzdf1VHFpOxfQh/ez7wyadLMqkg==
"@rollup/plugin-node-resolve@11.2.0":
version "11.2.0"
resolved "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-11.2.0.tgz#a5ab88c35bb7622d115f44984dee305112b6f714"
integrity sha512-qHjNIKYt5pCcn+5RUBQxK8krhRvf1HnyVgUCcFFcweDS7fhkOLZeYh0mhHK6Ery8/bb9tvN/ubPzmfF0qjDCTA==
dependencies:
"@rollup/pluginutils" "^3.1.0"
"@types/resolve" "1.17.1"
builtin-modules "^3.1.0"
deepmerge "^4.2.2"
is-module "^1.0.0"
resolve "^1.17.0"
resolve "^1.19.0"

"@rollup/[email protected]":
version "2.0.0"
Expand Down Expand Up @@ -8964,7 +8964,7 @@ is-ci@^2.0.0:
dependencies:
ci-info "^2.0.0"

is-core-module@^2.1.0:
is-core-module@^2.1.0, is-core-module@^2.2.0:
version "2.2.0"
resolved "https://registry.npmjs.org/is-core-module/-/is-core-module-2.2.0.tgz#97037ef3d52224d85163f5597b2b63d9afed981a"
integrity sha512-XRAfAdyyY5F5cOXn7hYQDqh2Xmii+DEfIcQGxK/uNwMHhIkPWO0g8msXcbzLe+MpGoR951MlqM/2iIlU4vKDdQ==
Expand Down Expand Up @@ -13427,6 +13427,14 @@ resolve@^1.1.6, resolve@^1.1.7, resolve@^1.10.0, resolve@^1.13.1, resolve@^1.17.
is-core-module "^2.1.0"
path-parse "^1.0.6"

resolve@^1.19.0:
version "1.20.0"
resolved "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz#629a013fb3f70755d6f0b7935cc1c2c5378b1975"
integrity sha512-wENBPt4ySzg4ybFQW2TT1zMQucPK95HSh/nq2CFTZVOGut2+pQvSsgtda4d26YrYcr067wjbmzOG8byDPBX63A==
dependencies:
is-core-module "^2.2.0"
path-parse "^1.0.6"

responselike@^1.0.2:
version "1.0.2"
resolved "https://registry.npmjs.org/responselike/-/responselike-1.0.2.tgz#918720ef3b631c5642be068f15ade5a46f4ba1e7"
Expand Down