Remove RepoManager #4520
Merged
Remove RepoManager #4520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
|
Feiyang1
reviewed
Feb 24, 2021
| /** | ||
| * Update an existing repo in place to point to a new host/port. | ||
| */ | ||
| export function repoManagerApplyEmulatorSettings( |
There was a problem hiding this comment.
Since repoManager is removed, do we still want the prefix?
There was a problem hiding this comment.
Yeah, I want to keep it to be able to translate these API calls between iOS, Android and Web.
Feiyang1
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the RepManager, which was only used as a singleton. It is replaced with two const variables. All functions are moved to be tree-shakeable (interrupt() and resume() were removed since they are not used).