Miscellaneous fixes for the exp release and reference doc generation #4521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
approved these changes
Feb 24, 2021
| @@ -44,7 +44,8 @@ | |||
| "test:node:persistence:prod": "node ./scripts/run-tests.js --main=index.node.ts --persistence 'test/{,!(browser|lite)/**/}*.test.ts'", | |||
| "test:travis": "ts-node --compiler-options='{\"module\":\"commonjs\"}' ../../scripts/emulator-testing/firestore-test-runner.ts", | |||
| "test:minified": "(cd ../../integration/firestore ; yarn test)", | |||
| "api-report": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ./scripts/api-report.ts", | |||
| "api-report": "yarn api-report:api-json && TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ./scripts/api-report.ts", | |||
| "api-report:api-json": "rm -rf temp && api-extractor run --local --verbose", | |||
There was a problem hiding this comment.
I assume "rm -rf temp" is intentional.
hsubox76
previously approved these changes
Feb 24, 2021
hsubox76
reviewed
Feb 24, 2021
| @@ -44,7 +44,8 @@ | |||
| "test:node:persistence:prod": "node ./scripts/run-tests.js --main=index.node.ts --persistence 'test/{,!(browser|lite)/**/}*.test.ts'", | |||
| "test:travis": "ts-node --compiler-options='{\"module\":\"commonjs\"}' ../../scripts/emulator-testing/firestore-test-runner.ts", | |||
| "test:minified": "(cd ../../integration/firestore ; yarn test)", | |||
| "api-report": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ./scripts/api-report.ts", | |||
| "api-report": "yarn api-report:api-json && TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' ts-node ./scripts/api-report.ts", | |||
| "api-report:api-json": "rm -rf temp && api-extractor run --local --verbose", | |||
There was a problem hiding this comment.
Does the rollup build have to happen first? CI is complaining it can't find the mainEntryPointFilePath d.ts file which I think is generated during the build, but the api-report command here is run during prebuild?
There was a problem hiding this comment.
Oh good catch. api-report:api-json should run after ts-node ./scripts/api-report.ts which creates the pruned d.ts files.
Binary Size ReportAffected SDKsNo changes between base commit (636dd78) and head commit (f806f4f). Test Logs
|
hsubox76
approved these changes
Feb 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.