Skip to content

Fix up the redirect persistence storage in Auth Compat #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2021
Merged

Fix up the redirect persistence storage in Auth Compat #4537

merged 2 commits into from
Feb 26, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 25, 2021

This change does a couple things:

  • Saves redirect storage in reauth and link methods as well
  • Fixes a bug where redirect would fail if called immediately after library load (i.e. firebase.auth().signInWithRedirect() where firebase.auth() is the first call to auth())

@sam-gc sam-gc requested a review from yuchenshi February 25, 2021 21:46
@sam-gc sam-gc requested a review from avolkovi as a code owner February 25, 2021 21:46
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (3862071) and head commit (3f2c4f3).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (3862071) and head commit (3f2c4f3).

@sam-gc sam-gc merged commit c3e5d5a into master Feb 26, 2021
@sam-gc sam-gc deleted the samgho/compat-redirect-persistence branch February 26, 2021 17:11
@firebase firebase locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi