Skip to content

Tree-shake ViewCache #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Tree-shake ViewCache #4613

merged 1 commit into from
Mar 12, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@schmidt-sebastian schmidt-sebastian requested a review from jsdt as a code owner March 10, 2021 19:05
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2021

⚠️ No Changeset found

Latest commit: 2e00b76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (13686cb) Head (5d5fd77) Diff
    browser 275 kB 275 kB -256 B (-0.1%)
    esm2017 248 kB 248 kB -41 B (-0.0%)
    main 277 kB 277 kB -256 B (-0.1%)
    module 275 kB 275 kB -256 B (-0.1%)
  • @firebase/database-exp

    Type Base (13686cb) Head (5d5fd77) Diff
    browser 272 kB 272 kB -256 B (-0.1%)
    esm2017 245 kB 245 kB -41 B (-0.0%)
    main 273 kB 273 kB -256 B (-0.1%)
    module 272 kB 272 kB -256 B (-0.1%)
  • firebase

    Type Base (13686cb) Head (5d5fd77) Diff
    firebase-database.js 178 kB 177 kB -847 B (-0.5%)
    firebase.js 839 kB 838 kB -847 B (-0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (13686cb) and head commit (5d5fd77).

new CacheNode(serverSnap, complete, filtered)
);
}
export function newViewCache(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: How about createViewCache(), which sounds more natural for a function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new is the pattern I have been using both in Firestore and in Database.

@Feiyang1 Feiyang1 removed their assignment Mar 12, 2021
@schmidt-sebastian schmidt-sebastian merged commit 35fdb93 into master Mar 12, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/viewcache branch March 12, 2021 21:50
@firebase firebase locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants