Skip to content

[Auth] Fix a type error in one of our tests #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2021
Merged

[Auth] Fix a type error in one of our tests #4624

merged 2 commits into from
Mar 15, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 12, 2021

No description provided.

@sam-gc sam-gc requested a review from yuchenshi March 12, 2021 19:10
@sam-gc sam-gc requested a review from avolkovi as a code owner March 12, 2021 19:10
@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2021

⚠️ No Changeset found

Latest commit: addb6d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (b6a7a59) and head commit (a2fb9e0).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (b6a7a59) and head commit (a2fb9e0).

Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks magical top me but I trust that you know what you're doing.

@sam-gc
Copy link
Contributor Author

sam-gc commented Mar 15, 2021

I think the compiler just got stricter in a recent TS version bump or something

@sam-gc sam-gc merged commit 4e7c78b into master Mar 15, 2021
@sam-gc sam-gc deleted the samgho/broken branch March 15, 2021 21:44
@firebase firebase locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants