Skip to content

[Auth] Add integration test framework to compatibility layer. #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 16, 2021
Merged

[Auth] Add integration test framework to compatibility layer. #4642

merged 6 commits into from
Mar 16, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 16, 2021

As a proof of concept, this PR also ports of the anonymous tests from the modular package.

I've update the typings for the compat package to fully match the Closure SDK as well

@sam-gc sam-gc requested a review from yuchenshi March 16, 2021 18:20
@sam-gc sam-gc requested a review from avolkovi as a code owner March 16, 2021 18:20
@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 88ca515

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (a6d29aa) and head commit (88f6d4e) are too large (470,788 characters) to display.

Please check below links to see details from the original test log.

@sam-gc sam-gc force-pushed the samgho/integration-compat branch from 4250043 to 88ca515 Compare March 16, 2021 19:41
@sam-gc sam-gc merged commit dfa20ff into master Mar 16, 2021
@sam-gc sam-gc deleted the samgho/integration-compat branch March 16, 2021 20:10
@firebase firebase locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi