Skip to content

Export the compat implementation for FieldPath and FieldValue #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2021
Merged

Export the compat implementation for FieldPath and FieldValue #4656

merged 3 commits into from
Mar 19, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Mar 19, 2021 •
edited
Loading

Changes:

  • export compat FieldValue and FieldPath from firestore-compat
  • export Compat from exp, so instanceof works correctly across packages
    • This is a stopgap solution till we implement the interop proposal for all packages.

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d141d8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (1db2c3a) and head commit (00800f8).

thebrianchen
thebrianchen approved these changes Mar 19, 2021
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Feiyang1 Feiyang1 merged commit f7288bb into master Mar 19, 2021
@Feiyang1 Feiyang1 deleted the fei-fieldpath-compat branch March 19, 2021 19:14
@firebase firebase locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @thebrianchen @schmidt-sebastian