Skip to content

[Auth] Update compat layer credential interception; add webdriver tests #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 24, 2021
Merged

[Auth] Update compat layer credential interception; add webdriver tests #4669

merged 10 commits into from
Mar 24, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 22, 2021

The compat layer uses the existing webdriver tests here; we swap out the JS source served to the browser to use the compat layer (keeping the same function names)

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1f449f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sam-gc sam-gc requested a review from yuchenshi March 22, 2021 22:43
@sam-gc sam-gc marked this pull request as ready for review March 22, 2021 22:43
@sam-gc sam-gc requested a review from avolkovi as a code owner March 22, 2021 22:43
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 22, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (de5f905) and head commit (a012c48) are too large (474,633 characters) to display.

Please check below links to see details from the original test log.

yuchenshi
yuchenshi reviewed Mar 23, 2021
View reviewed changes
yuchenshi
yuchenshi reviewed Mar 23, 2021
View reviewed changes
packages-exp/auth-compat-exp/test/integration/webdriver/static/persistence.js
};
}

function dumpStorage(storage) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like duplicating the test helper functions themselves. Maybe we should split test helpers into their own files and only make code under test different. We can think about this later though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fair. We'll need to separate the parts that invoke the SDK in that case

@sam-gc sam-gc force-pushed the samgho/compat-webdriver-2 branch from 418f37c to 1f449f6 Compare March 24, 2021 20:13
@sam-gc sam-gc merged commit 05f5bf3 into master Mar 24, 2021
@sam-gc sam-gc deleted the samgho/compat-webdriver-2 branch March 24, 2021 20:51
@firebase firebase locked and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi