Create index.d.ts for firebase-exp compat packages #4689

hsubox76 · 2021-03-30T20:03:55Z

Copy master index.d.ts from packages/firebase to packages-exp/firebase-exp/compat, and update to match types exported by compat packages.

In several cases, compat packages are using types from -types packages to define the service and other top level exports, and those are pretty close to index.d.ts, so doesn't seem like much updating was needed?

changeset-bot · 2021-03-30T20:03:58Z

⚠️ No Changeset found

Latest commit: a65c251

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2021-03-30T21:05:23Z

Size Analysis Report

Affected Products

`@firebase/analytics-exp`

`getAnalytics`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	9.04 kB	9.08 kB	+40 B (+0.4%)
size-with-ext-deps	26.6 kB	26.7 kB	+85 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

`isSupported`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	9.10 kB	9.13 kB	+33 B (+0.4%)
size-with-ext-deps	26.7 kB	26.8 kB	+78 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

`logEvent`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	8.96 kB	8.99 kB	+34 B (+0.4%)
size-with-ext-deps	26.6 kB	26.6 kB	+78 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

`setAnalyticsCollectionEnabled`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	9.11 kB	9.15 kB	+40 B (+0.4%)
size-with-ext-deps	26.7 kB	26.8 kB	+85 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

`setCurrentScreen`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	9.20 kB	9.24 kB	+40 B (+0.4%)
size-with-ext-deps	26.8 kB	26.9 kB	+85 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

`setUserId`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	9.18 kB	9.22 kB	+40 B (+0.4%)
size-with-ext-deps	26.8 kB	26.9 kB	+85 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

`setUserProperties`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	9.26 kB	9.30 kB	+40 B (+0.4%)
size-with-ext-deps	26.9 kB	27.0 kB	+85 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

`settings`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	9.08 kB	9.12 kB	+33 B (+0.4%)
size-with-ext-deps	26.7 kB	26.8 kB	+78 B (+0.3%)

External Dependency Table

Module Base (3aa0b36) Head (fa8dac7) Diff

@firebase/util

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

ErrorFactory
FirebaseError
areCookiesEnabled
calculateBackoffMillis
getModularInstance
isBrowserExtension
isIndexedDBAvailable
validateIndexedDBOpenable

+ getModularInstance

@firebase/messaging-exp
- deleteToken
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  7.51 kB
  7.54 kB
  +31 B (+0.4%)
  size-with-ext-deps
  24.4 kB
  24.5 kB
  +80 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory
  ErrorFactory getModularInstance
  + getModularInstance
- getMessaging
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  3.67 kB
  3.70 kB
  +31 B (+0.8%)
  size-with-ext-deps
  20.5 kB
  20.6 kB
  +80 B (+0.4%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory
  ErrorFactory getModularInstance
  + getModularInstance
- getToken
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  12.0 kB
  12.1 kB
  +37 B (+0.3%)
  size-with-ext-deps
  29.0 kB
  29.1 kB
  +80 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory
  ErrorFactory getModularInstance
  + getModularInstance
- onBackgroundMessage
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  13.2 kB
  13.2 kB
  +33 B (+0.3%)
  size-with-ext-deps
  30.1 kB
  30.2 kB
  +80 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory
  ErrorFactory getModularInstance
  + getModularInstance
- onMessage
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  5.19 kB
  5.22 kB
  +31 B (+0.6%)
  size-with-ext-deps
  22.1 kB
  22.1 kB
  +80 B (+0.4%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory
  ErrorFactory getModularInstance
  + getModularInstance

`@firebase/performance-exp`

`getPerformance`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	17.4 kB	17.4 kB	+33 B (+0.2%)
size-with-ext-deps	34.6 kB	34.7 kB	+80 B (+0.2%)

External Dependency Table

Module	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
`@firebase/util`	ErrorFactory isIndexedDBAvailable validateIndexedDBOpenable	ErrorFactory getModularInstance isIndexedDBAvailable validateIndexedDBOpenable	+ getModularInstance

`initializePerformance`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	17.4 kB	17.5 kB	+33 B (+0.2%)
size-with-ext-deps	34.7 kB	34.8 kB	+80 B (+0.2%)

External Dependency Table

Module	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
`@firebase/util`	ErrorFactory isIndexedDBAvailable validateIndexedDBOpenable	ErrorFactory getModularInstance isIndexedDBAvailable validateIndexedDBOpenable	+ getModularInstance

`trace`

Size Table

Type	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
size	17.3 kB	17.3 kB	+33 B (+0.2%)
size-with-ext-deps	34.6 kB	34.7 kB	+80 B (+0.2%)

External Dependency Table

Module	Base (`3aa0b36`)	Head (`fa8dac7`)	Diff
`@firebase/util`	ErrorFactory isIndexedDBAvailable validateIndexedDBOpenable	ErrorFactory getModularInstance isIndexedDBAvailable validateIndexedDBOpenable	+ getModularInstance

@firebase/remote-config-exp
- activate
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  10.4 kB
  10.4 kB
  +30 B (+0.3%)
  size-with-ext-deps
  27.4 kB
  27.4 kB
  +80 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- ensureInitialized
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  10.1 kB
  10.1 kB
  +27 B (+0.3%)
  size-with-ext-deps
  27.1 kB
  27.1 kB
  +77 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- fetchAndActivate
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  11.0 kB
  11.0 kB
  +40 B (+0.4%)
  size-with-ext-deps
  28.0 kB
  28.1 kB
  +90 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- fetchConfig
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  10.6 kB
  10.6 kB
  +30 B (+0.3%)
  size-with-ext-deps
  27.6 kB
  27.7 kB
  +80 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- getAll
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  11.2 kB
  11.3 kB
  +33 B (+0.3%)
  size-with-ext-deps
  28.2 kB
  28.3 kB
  +83 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- getBoolean
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  11.1 kB
  11.1 kB
  +33 B (+0.3%)
  size-with-ext-deps
  28.1 kB
  28.2 kB
  +83 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- getNumber
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  11.1 kB
  11.1 kB
  +33 B (+0.3%)
  size-with-ext-deps
  28.1 kB
  28.2 kB
  +83 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- getRemoteConfig
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  10.1 kB
  10.2 kB
  +34 B (+0.3%)
  size-with-ext-deps
  27.1 kB
  27.2 kB
  +84 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- getString
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  11.1 kB
  11.1 kB
  +33 B (+0.3%)
  size-with-ext-deps
  28.1 kB
  28.2 kB
  +83 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- getValue
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  11.0 kB
  11.1 kB
  +30 B (+0.3%)
  size-with-ext-deps
  28.0 kB
  28.1 kB
  +80 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance
- setLogLevel
  Size Table
  Type Base (3aa0b36) Head (fa8dac7) Diff
  size
  10.2 kB
  10.3 kB
  +30 B (+0.3%)
  size-with-ext-deps
  27.2 kB
  27.3 kB
  +80 B (+0.3%)
  External Dependency Table
  Module Base (3aa0b36) Head (fa8dac7) Diff
  @firebase/util
  ErrorFactory FirebaseError calculateBackoffMillis
  ErrorFactory FirebaseError calculateBackoffMillis getModularInstance
  + getModularInstance

Test Logs

Feiyang1

Approved pending moving the test to an integration test project

github-actions · 2021-03-31T20:25:58Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

Feiyang1 · 2021-03-31T20:36:38Z

packages-exp/messaging-compat/src/messaging-compat.js

+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+var __awaiter =


hsubox76 added 4 commits March 30, 2021 11:07

Did analytics, app, auth

7443c83

Finish first pass

9facb98

Revert extra changes

604ea64

Merge branch 'master' into ch-index-types

e33deb8

hsubox76 requested review from Feiyang1 and hiranya911 as code owners March 30, 2021 20:03

Update year in license

8394a3a

Add test file, fix index.d.ts and messaging-compat

d36676c

Feiyang1 approved these changes Mar 31, 2021

View reviewed changes

Clean up test npm script

f9f1090

Add new integration test to ignore list

da13c54

Feiyang1 suggested changes Mar 31, 2021

View reviewed changes

hsubox76 added 2 commits March 31, 2021 13:42

Clean up

c5b4c75

Add new integration test to test-changed core ignore

f20bbfa

Feiyang1 approved these changes Mar 31, 2021

View reviewed changes

hsubox76 added 7 commits March 31, 2021 14:16

Point firebase-exp/compat/app typings to big index.d.ts

03004a3

Merge branch 'master' into ch-index-types

f78a559

Remove _delegate from public FirebaseApp compat type

e5e2b57

Add firebase.User

cae82b5

Remove _delegate from fake test apps

be0cea2

Merge branch 'master' into ch-index-types

7ecdef3

Revert yarn lock?

a65c251

hsubox76 merged commit 340ce5c into master Apr 1, 2021

hsubox76 deleted the ch-index-types branch April 1, 2021 02:37

firebase locked and limited conversation to collaborators May 2, 2021

Create index.d.ts for firebase-exp compat packages #4689

Create index.d.ts for firebase-exp compat packages #4689

Uh oh!

Conversation

hsubox76 commented Mar 30, 2021

Uh oh!

changeset-bot bot commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/analytics-exp

getAnalytics

isSupported

logEvent

setAnalyticsCollectionEnabled

setCurrentScreen

setUserId

setUserProperties

settings

@firebase/messaging-exp

deleteToken

getMessaging

getToken

onBackgroundMessage

onMessage

@firebase/performance-exp

getPerformance

initializePerformance

trace

@firebase/remote-config-exp

activate

ensureInitialized

fetchAndActivate

fetchConfig

getAll

getBoolean

getNumber

getRemoteConfig

getString

getValue

setLogLevel

Test Logs

Uh oh!

Feiyang1 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset File Check ✅

Uh oh!

Feiyang1 Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

hsubox76 Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Mar 30, 2021 •

edited

Loading

google-oss-bot commented Mar 30, 2021 •

edited

Loading

`@firebase/analytics-exp`

`getAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setCurrentScreen`

`setUserId`

`setUserProperties`

`settings`

`@firebase/messaging-exp`

`deleteToken`

`getMessaging`

`getToken`

`onBackgroundMessage`

`onMessage`

`@firebase/performance-exp`

`getPerformance`

`initializePerformance`

`trace`

`@firebase/remote-config-exp`

`activate`

`ensureInitialized`

`fetchAndActivate`

`fetchConfig`

`getAll`

`getBoolean`

`getNumber`

`getRemoteConfig`

`getString`

`getValue`

`setLogLevel`

github-actions bot commented Mar 31, 2021 •

edited

Loading