Skip to content

Support logging frameworks. #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 2, 2021
Merged

Support logging frameworks. #4693

merged 13 commits into from
Apr 2, 2021

Conversation

yuchenshi
Copy link
Member

This fixes b/166287561. It sets endpoints and frameworks on iframe correctly, and it also allows logging frameworks in other APIs.

@yuchenshi yuchenshi requested a review from sam-gc March 31, 2021 01:45
@yuchenshi yuchenshi requested a review from avolkovi as a code owner March 31, 2021 01:45
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 15ff00b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (c14e052) and head commit (1912264) are too large (477,169 characters) to display.

Please check below links to see details from the original test log.

@yuchenshi yuchenshi merged commit a4b794b into master Apr 2, 2021
@yuchenshi yuchenshi deleted the ys/auth-exp-logFramework branch April 2, 2021 01:12
@firebase firebase locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuchenshi @google-oss-bot @sam-gc