Skip to content

Ensure eventParams is optional in all logEvent overloads #4707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2021
Merged

Ensure eventParams is optional in all logEvent overloads #4707

merged 3 commits into from
Apr 5, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 1, 2021

The ? only got added to the first overload for some reason.

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 230e1e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 merged commit 65a4e85 into master Apr 5, 2021
@hsubox76 hsubox76 deleted the ch-analytics-types-fix branch April 5, 2021 20:34
@firebase firebase locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubox76 @Feiyang1