Skip to content

fix RTDB build #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix RTDB build #4777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e273c29
fix rtdb build
Feiyang1 Apr 13, 2021
e975964
Create hip-dingos-judge.md
Feiyang1 Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-dingos-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/database": patch
---

Fix a build issue that caused SDK breakage.
15 changes: 12 additions & 3 deletions packages/database/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ const es5Builds = [
output: [{ file: pkg.main, format: 'cjs', sourcemap: true }],
plugins: es5BuildPlugins,
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
onwarn: onWarn
onwarn: onWarn,
treeshake: {
moduleSideEffects: false
}
},
/**
* Browser Builds
Expand All @@ -60,7 +63,10 @@ const es5Builds = [
output: [{ file: pkg.module, format: 'es', sourcemap: true }],
plugins: es5BuildPlugins,
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
onwarn: onWarn
onwarn: onWarn,
treeshake: {
moduleSideEffects: false
}
}
];

Expand Down Expand Up @@ -88,7 +94,10 @@ const es2017Builds = [
output: [{ file: pkg.esm2017, format: 'es', sourcemap: true }],
plugins: es2017BuildPlugins,
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
onwarn: onWarn
onwarn: onWarn,
treeshake: {
moduleSideEffects: false
}
}
];

Expand Down