Skip to content

Fix DatastoreImpl.terminate() to actually set the terminated flag. #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2021
Merged

Fix DatastoreImpl.terminate() to actually set the terminated flag. #4785

merged 2 commits into from
Apr 15, 2021

Conversation

dconeybe
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: a03b083

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmidt-sebastian schmidt-sebastian removed their assignment Apr 14, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (d680986) Head (1af13bb) Diff
    main 528 kB 528 kB -1 B (-0.0%)

  • @firebase/firestore-exp

    Type Base (d680986) Head (1af13bb) Diff
    main 505 kB 505 kB -1 B (-0.0%)

  • @firebase/firestore-lite

    Type Base (d680986) Head (1af13bb) Diff
    main 145 kB 145 kB -1 B (-0.0%)

  • @firebase/firestore/bundle

    Type Base (d680986) Head (1af13bb) Diff
    main 525 kB 525 kB -1 B (-0.0%)

  • @firebase/firestore/memory

    Type Base (d680986) Head (1af13bb) Diff
    main 323 kB 323 kB -1 B (-0.0%)

  • @firebase/firestore/memory-bundle

    Type Base (d680986) Head (1af13bb) Diff
    main 320 kB 320 kB -1 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (d680986) and head commit (1af13bb) are too large (479,509 characters) to display.

Please check below links to see details from the original test log.

@dconeybe dconeybe merged commit 31126af into master Apr 15, 2021
@dconeybe dconeybe deleted the dconeybe/FixDatastoreTerminate branch April 15, 2021 17:29
@firebase firebase locked and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @schmidt-sebastian