Skip to content

Fix cancelCallback for child_added events #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

Fixes #4818

This simplifies the code in ChildEventRegistration. The class is meant to support multiple callbacks, but only one cancel callback. This broke in our refactor. Luckily, the class is never used for more than callback, so I was able to simplify the code and also fix the bug (which was due to the fact that the cancel callback was never registered under 'cancel').

@schmidt-sebastian schmidt-sebastian requested a review from jsdt as a code owner April 24, 2021 01:57
@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2021

🦋 Changeset detected

Latest commit: 4c804a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/database Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2021

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (d47fb41) Head (31f6dca) Diff
    browser 291 kB 291 kB -525 B (-0.2%)
    esm2017 261 kB 261 kB -499 B (-0.2%)
    main 294 kB 293 kB -530 B (-0.2%)
    module 291 kB 291 kB -525 B (-0.2%)
  • @firebase/database-exp

    Type Base (d47fb41) Head (31f6dca) Diff
    browser 242 kB 242 kB -499 B (-0.2%)
    main 273 kB 273 kB -530 B (-0.2%)
    module 242 kB 242 kB -499 B (-0.2%)
  • firebase

    Type Base (d47fb41) Head (31f6dca) Diff
    firebase-database.js 183 kB 183 kB -258 B (-0.1%)
    firebase.js 869 kB 869 kB -259 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (d47fb41) and head commit (31f6dca) are too large (479,509 characters) to display.

Please check below links to see details from the original test log.

@schmidt-sebastian schmidt-sebastian merged commit 8d63eac into master Apr 27, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/cancel branch April 27, 2021 18:44
@google-oss-bot google-oss-bot mentioned this pull request Apr 27, 2021
@firebase firebase locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handlers no longer being called for reference listeners, permission denied causes crash
3 participants