Fix cancelCallback for child_added events #4832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4818
This simplifies the code in ChildEventRegistration. The class is meant to support multiple callbacks, but only one cancel callback. This broke in our refactor. Luckily, the class is never used for more than callback, so I was able to simplify the code and also fix the bug (which was due to the fact that the cancel callback was never registered under 'cancel').