Skip to content

Publishing @firebase/messaging/sw to npm #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2021
Merged

Publishing @firebase/messaging/sw to npm #4904

merged 3 commits into from
May 13, 2021

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented May 13, 2021 •
edited
Loading

see b/187953503 for details.

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: ba90d22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zwu52 zwu52 changed the title Publishing sw to npm Publishing @firebase/messaging/sw to npm May 13, 2021
Feiyang1
Feiyang1 approved these changes May 13, 2021
View reviewed changes
@zwu52 zwu52 merged commit d20c576 into master May 13, 2021
@zwu52 zwu52 deleted the publish_sw branch May 13, 2021 22:16
@firebase firebase locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwu52 @Feiyang1