Skip to content

Add entry point firebase/messaging/sw #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2021
Merged

Add entry point firebase/messaging/sw #4938

merged 4 commits into from
May 25, 2021

Conversation

Feiyang1
Copy link
Member

Changes:

  • Add entry point firebase/messaging/sw
  • Remove CDN builds for modular packages (we only provide CDN builds for compat packages)

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2021

⚠️ No Changeset found

Latest commit: 883c01e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2021

Binary Size Report

Affected SDKs

  • @firebase/component

    Type Base (cc2132c) Head (f69260d) Diff
    browser 7.84 kB 7.95 kB +108 B (+1.4%)
    esm2017 5.88 kB 6.00 kB +122 B (+2.1%)
    main 8.18 kB 8.29 kB +111 B (+1.4%)
    module 7.84 kB 7.95 kB +108 B (+1.4%)
  • @firebase/firestore

    Type Base (cc2132c) Head (f69260d) Diff
    browser 284 kB 284 kB +157 B (+0.1%)
    esm2017 226 kB 226 kB +159 B (+0.1%)
    main 531 kB 531 kB +17 B (+0.0%)
    module 284 kB 284 kB +157 B (+0.1%)
    react-native 226 kB 226 kB +159 B (+0.1%)
  • @firebase/firestore-exp

    Type Base (cc2132c) Head (f69260d) Diff
    browser 224 kB 224 kB +160 B (+0.1%)
    main 510 kB 510 kB +17 B (+0.0%)
    module 224 kB 224 kB +160 B (+0.1%)
    react-native 224 kB 224 kB +159 B (+0.1%)
  • @firebase/firestore-lite

    Type Base (cc2132c) Head (f69260d) Diff
    browser 72.4 kB 72.6 kB +178 B (+0.2%)
    main 149 kB 149 kB +33 B (+0.0%)
    module 72.4 kB 72.6 kB +178 B (+0.2%)
    react-native 72.6 kB 72.8 kB +178 B (+0.2%)
  • @firebase/firestore/bundle

    Type Base (cc2132c) Head (f69260d) Diff
    browser 290 kB 290 kB +161 B (+0.1%)
    esm2017 176 kB 176 kB +163 B (+0.1%)
    main 527 kB 527 kB +17 B (+0.0%)
    module 290 kB 290 kB +161 B (+0.1%)
    react-native 176 kB 177 kB +163 B (+0.1%)
  • @firebase/firestore/memory

    Type Base (cc2132c) Head (f69260d) Diff
    browser 216 kB 216 kB +165 B (+0.1%)
    esm2017 172 kB 172 kB +163 B (+0.1%)
    main 325 kB 325 kB +31 B (+0.0%)
    module 216 kB 216 kB +165 B (+0.1%)
    react-native 172 kB 172 kB +163 B (+0.1%)
  • @firebase/firestore/memory-bundle

    Type Base (cc2132c) Head (f69260d) Diff
    browser 224 kB 224 kB +165 B (+0.1%)
    esm2017 176 kB 176 kB +163 B (+0.1%)
    main 322 kB 322 kB +31 B (+0.0%)
    module 224 kB 224 kB +165 B (+0.1%)
    react-native 176 kB 177 kB +163 B (+0.1%)
  • firebase

    Type Base (cc2132c) Head (f69260d) Diff
    firebase-app.js 21.8 kB 21.8 kB +49 B (+0.2%)
    firebase-database.js 187 kB 187 kB +49 B (+0.0%)
    firebase-firestore.js 332 kB 332 kB +180 B (+0.1%)
    firebase-firestore.memory.js 267 kB 267 kB +184 B (+0.1%)
    firebase-performance-standalone.es2017.js 73.1 kB 73.2 kB +50 B (+0.1%)
    firebase-performance-standalone.js 49.6 kB 49.7 kB +49 B (+0.1%)
    firebase.js 888 kB 889 kB +228 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2021

Size Analysis Report

Affected Products

  • @firebase/app-exp

    • initializeApp

      Size Table

      TypeBase (cc2132c)Head (f69260d)Diff
      size-with-ext-deps
      11.0 kB
      11.1 kB
      +84 B (+0.8%)

Copy link
Member

@zwu52 zwu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for the changes here 👍 some nits

@Feiyang1 Feiyang1 merged commit 7f950c9 into master May 25, 2021
@Feiyang1 Feiyang1 deleted the fei-fcm-sw branch May 25, 2021 23:26
@firebase firebase locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants