Skip to content

fix onAuthStateChanged binding #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2021
Merged

fix onAuthStateChanged binding #4945

merged 1 commit into from
May 27, 2021

Conversation

uny
Copy link
Contributor

@uny uny commented May 27, 2021

fixes: #4937

@uny uny requested review from avolkovi, sam-gc and yuchenshi as code owners May 27, 2021 10:36
@changeset-bot
Copy link

changeset-bot bot commented May 27, 2021

⚠️ No Changeset found

Latest commit: 2ee59e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sam-gc
sam-gc approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yuchenshi yuchenshi merged commit 22c2621 into firebase:master May 27, 2021
@firebase firebase locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modular SDK throws an error in rxjs
3 participants
@uny @sam-gc @yuchenshi