Fix app-check-compat initialization

[hsubox76]

Try to fix app-check-compat's activate() incorrectly throwing an error that app check has already been initialized. This happens because app-check-compat's factory initializes app-check-exp, which means when the compat activate() calls exp's initializeAppCheck() it is too late, it has already been initialized.

This approach avoids initializing app-check-exp until activate() is called. This means the AppCheck compat service's _delegate is going to be empty at initialization. That should be fine because all the other app check compat methods can throw an error asking the user to call activate() first. I think app check compat should have its own error anyway. If they hit the error in the called exp function, it asks you to "call initializeAppCheck() first" which doesn't exist in compat.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 075f975

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Changeset File Check ⚠️

• Changeset formatting error in following file:

  Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
  Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
  Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
  Error: Failed to find where HEAD diverged from master. Does master exist?
      at async getChangedFilesSince (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:169:22)
      at async Object.getChangedPackagesSinceRef (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:208:24)
      at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:977:27)
      at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)
  

[google-oss-bot]

Size Analysis Report

Affected Products

No changes between base commit (ca85752) and head commit (c9fbc9a).

Test Logs

• Base (ca85752): https://github.com/firebase/firebase-js-sdk/actions/runs/988528009
• Head (c9fbc9a): https://github.com/firebase/firebase-js-sdk/actions/runs/988652346

[Feiyang1]

We should set the instantiation mode of components app-check-exp and app-check-internal to explicit by chaining .setInstantiationMode(InstantiationMode.EXPLICIT) when creating the components.

[Feiyang1]

We should check if AppCheck is already initialized first. If it is, we will just get it through provider.getImmediate(); This can happen if both app-check and app-check-compat are included in an app and app-check is initialized first.

[Feiyang1]

hm, that doesn't seem to be a valid use case because people need to provide a provider to activate, so if they are using app-check-compat, they should use activate and never call initializeAppCheck() from the modular package.