Skip to content

change the instantiation mode to explicit for appcheck #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Jul 1, 2021

AppCheck shouldn't be able to be instantiated by consumers by using Provider.get() or Provider.getImmediate(). Rather it should become available when it's explicitly initialized by developers by calling initializeAppCheck() and passing it an AppCheckProvider.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2021

⚠️ No Changeset found

Latest commit: 462b83a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.5" vs "file:../../packages-exp/firebase-exp"
    Error: Failed to find where HEAD diverged from master. Does master exist?
        at async getChangedFilesSince (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:169:22)
        at async Object.getChangedPackagesSinceRef (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:208:24)
        at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:977:27)
        at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)
    

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/app-check-exp

    • CustomProvider

      Size Table

      TypeBase (f6e1645)Head (340c55a)Diff
      size
      9.67 kB
      9.81 kB
      +138 B (+1.4%)
      size-with-ext-deps
      19.5 kB
      19.6 kB
      +138 B (+0.7%)
    • ReCaptchaV3Provider

      Size Table

      TypeBase (f6e1645)Head (340c55a)Diff
      size
      11.0 kB
      11.1 kB
      +138 B (+1.3%)
      size-with-ext-deps
      20.4 kB
      20.5 kB
      +138 B (+0.7%)
    • getToken

      Size Table

      TypeBase (f6e1645)Head (340c55a)Diff
      size
      9.38 kB
      9.52 kB
      +138 B (+1.5%)
      size-with-ext-deps
      18.7 kB
      18.9 kB
      +138 B (+0.7%)
    • initializeAppCheck

      Size Table

      TypeBase (f6e1645)Head (340c55a)Diff
      size
      9.80 kB
      9.93 kB
      +138 B (+1.4%)
      size-with-ext-deps
      19.3 kB
      19.5 kB
      +138 B (+0.7%)
    • onTokenChanged

      Size Table

      TypeBase (f6e1645)Head (340c55a)Diff
      size
      9.47 kB
      9.61 kB
      +138 B (+1.5%)
      size-with-ext-deps
      18.8 kB
      19.0 kB
      +138 B (+0.7%)
    • setTokenAutoRefreshEnabled

      Size Table

      TypeBase (f6e1645)Head (340c55a)Diff
      size
      9.51 kB
      9.65 kB
      +138 B (+1.5%)
      size-with-ext-deps
      18.9 kB
      19.0 kB
      +138 B (+0.7%)

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (f6e1645) and head commit (340c55a).

Test Logs

@Feiyang1 Feiyang1 merged commit f43d0c6 into master Jul 1, 2021
@Feiyang1 Feiyang1 deleted the fei-appcheck-explicit branch July 1, 2021 17:02
@firebase firebase locked and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants