[Auth] Break down event ID digits to a max Math.random() digit count #5098

sam-gc · 2021-07-01T19:12:16Z

This addresses b/184782003

changeset-bot · 2021-07-01T19:12:34Z

⚠️ No Changeset found

Latest commit: 2e486fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2021-07-01T19:15:41Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Error: Failed to find where HEAD diverged from master. Does master exist?
    at async getChangedFilesSince (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:169:22)
    at async Object.getChangedPackagesSinceRef (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:208:24)
    at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:977:27)
    at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)

packages-exp/auth-exp/src/core/util/event_id.ts

google-oss-bot · 2021-07-01T19:40:43Z

Binary Size Report

Affected SDKs

No changes between base commit (61f0d7e) and head commit (35a59e0).

Test Logs

Base (61f0d7ed): https://github.com/firebase/firebase-js-sdk/actions/runs/990971785
Head (35a59e0d): https://github.com/firebase/firebase-js-sdk/actions/runs/991352202

google-oss-bot · 2021-07-01T19:44:04Z

Size Analysis Report

Affected Products

`@firebase/auth-exp`

getAuth
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
60.9 kB
60.8 kB
-43 B (-0.1%)
size-with-ext-deps
73.1 kB
73.0 kB
-43 B (-0.1%)
Dependency Table
Type Base (61f0d7e) Head (35a59e0) Diff
functions
<full-list-too-large-to-display> <see-test-logs-below-for-details>
<full-list-too-large-to-display> <see-test-logs-below-for-details>
- generateEventId
getRedirectResult
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
36.9 kB
37.0 kB
+31 B (+0.1%)
size-with-ext-deps
48.8 kB
48.8 kB
+31 B (+0.1%)
linkWithPopup
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
40.3 kB
40.3 kB
+31 B (+0.1%)
size-with-ext-deps
52.2 kB
52.2 kB
+31 B (+0.1%)
linkWithRedirect
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
35.5 kB
35.5 kB
+31 B (+0.1%)
size-with-ext-deps
47.3 kB
47.4 kB
+31 B (+0.1%)
reauthenticateWithPopup
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
40.3 kB
40.3 kB
+31 B (+0.1%)
size-with-ext-deps
52.2 kB
52.2 kB
+31 B (+0.1%)
reauthenticateWithRedirect
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
35.2 kB
35.2 kB
+31 B (+0.1%)
size-with-ext-deps
47.1 kB
47.1 kB
+31 B (+0.1%)
signInWithPopup
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
40.3 kB
40.3 kB
+31 B (+0.1%)
size-with-ext-deps
52.2 kB
52.2 kB
+31 B (+0.1%)
browserPopupRedirectResolver
Size Table
Type Base (61f0d7e) Head (35a59e0) Diff
size
53.2 kB
53.2 kB
+31 B (+0.1%)
size-with-ext-deps
65.3 kB
65.3 kB
+31 B (+0.0%)

`indexedDBLocalPersistence`

Size Table

Type	Base (`61f0d7e`)	Head (`35a59e0`)	Diff
size	36.8 kB	36.8 kB	+22 B (+0.1%)
size-with-ext-deps	48.6 kB	48.7 kB	+22 B (+0.0%)

Dependency Table

Type	Base (`61f0d7e`)	Head (`35a59e0`)	Diff
functions	<full-list-too-large-to-display> <see-test-logs-below-for-details>	<full-list-too-large-to-display> <see-test-logs-below-for-details>	+ _generateEventId - generateEventId

Test Logs

packages-exp/auth-exp/src/core/util/event_id.ts

sam-gc added 2 commits July 1, 2021 11:25

[Auth] Break down event ID digits to a max Math.random() digit count

f4dea01

License/formatting

aba10c0

sam-gc requested a review from yuchenshi July 1, 2021 19:12

sam-gc assigned yuchenshi Jul 1, 2021

sam-gc requested a review from avolkovi as a code owner July 1, 2021 19:12

avolkovi reviewed Jul 1, 2021

View reviewed changes

packages-exp/auth-exp/src/core/util/event_id.ts Outdated Show resolved Hide resolved

avolkovi reviewed Jul 1, 2021

View reviewed changes

packages-exp/auth-exp/src/core/util/event_id.ts Outdated Show resolved Hide resolved

src/core/util/event_id.ts

2e486fe

yuchenshi approved these changes Jul 2, 2021

View reviewed changes

sam-gc merged commit 3827d96 into master Jul 2, 2021

sam-gc deleted the sam-gc/random branch July 2, 2021 16:04

firebase locked and limited conversation to collaborators Aug 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Auth] Break down event ID digits to a max Math.random() digit count #5098

[Auth] Break down event ID digits to a max Math.random() digit count #5098

Uh oh!

sam-gc commented Jul 1, 2021

Uh oh!

changeset-bot bot commented Jul 1, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Jul 1, 2021

Uh oh!

Uh oh!

google-oss-bot commented Jul 1, 2021 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 1, 2021 •

edited

Loading

Affected Products

`@firebase/auth-exp`

`getAuth`

`getRedirectResult`

`linkWithPopup`

`linkWithRedirect`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`signInWithPopup`

`browserPopupRedirectResolver`

`indexedDBLocalPersistence`

Test Logs

Uh oh!

Uh oh!

Uh oh!

[Auth] Break down event ID digits to a max Math.random() digit count #5098

[Auth] Break down event ID digits to a max Math.random() digit count #5098

Uh oh!

Conversation

sam-gc commented Jul 1, 2021

Uh oh!

changeset-bot bot commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Jul 1, 2021

Changeset File Check ⚠️

Uh oh!

Uh oh!

google-oss-bot commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

Test Logs

Uh oh!

google-oss-bot commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/auth-exp

getAuth

getRedirectResult

linkWithPopup

linkWithRedirect

reauthenticateWithPopup

reauthenticateWithRedirect

signInWithPopup

browserPopupRedirectResolver

indexedDBLocalPersistence

Test Logs

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Jul 1, 2021 •

edited

Loading

google-oss-bot commented Jul 1, 2021 •

edited

Loading

google-oss-bot commented Jul 1, 2021 •

edited

Loading

`@firebase/auth-exp`

`getAuth`

`getRedirectResult`

`linkWithPopup`

`linkWithRedirect`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`signInWithPopup`

`browserPopupRedirectResolver`

`indexedDBLocalPersistence`