Skip to content

Update comments for v9 reference docs #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2021
Merged

Update comments for v9 reference docs #5111

merged 3 commits into from
Jul 3, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Jul 2, 2021

  • Add package description for AppCheck
  • Update links in Auth comments. It's not possible to link to a property of a variable, so we just link to the variable.
  • Remove unnecessary package specifiers in links

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2021

⚠️ No Changeset found

Latest commit: 7aea39a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Error: Failed to find where HEAD diverged from master. Does master exist?
        at async getChangedFilesSince (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:169:22)
        at async Object.getChangedPackagesSinceRef (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:208:24)
        at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:977:27)
        at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021

Binary Size Report

Affected SDKs

No changes between base commit (99414a5) and head commit (c93d241).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021

Size Analysis Report

Affected Products

Diffs between base commit (99414a5) and head commit (c93d241) are too large (517,485 characters) to display.

Please check below links to see details from the original test log.

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@Feiyang1 Feiyang1 merged commit 90252ca into master Jul 3, 2021
@Feiyang1 Feiyang1 deleted the fei-fix-ref branch July 3, 2021 00:17
@firebase firebase locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants