Skip to content

[Auth] Create index.doc.ts for generating docs for all platforms #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 2, 2021

I'm not sure how to wire up tsc/api-report

@sam-gc sam-gc requested a review from Feiyang1 July 2, 2021 22:25
@sam-gc sam-gc requested review from avolkovi and yuchenshi as code owners July 2, 2021 22:25
@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2021

⚠️ No Changeset found

Latest commit: 742d04e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Error: Failed to find where HEAD diverged from master. Does master exist?
        at async getChangedFilesSince (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:169:22)
        at async Object.getChangedPackagesSinceRef (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:208:24)
        at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:977:27)
        at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)
    

@Feiyang1 Feiyang1 assigned sam-gc and unassigned Feiyang1 Jul 2, 2021
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (99414a5) and head commit (03dfb9b).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (99414a5) and head commit (03dfb9b) are too large (517,485 characters) to display.

Please check below links to see details from the original test log.

@sam-gc sam-gc merged commit 977edee into master Jul 3, 2021
@sam-gc sam-gc deleted the sam-gc/index.doc.ts branch July 3, 2021 01:37
@firebase firebase locked and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants