Skip to content

Update type names in v9 API #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 27, 2021
Merged

Update type names in v9 API #5137

merged 10 commits into from
Jul 27, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@Feiyang1 Feiyang1 added the v9 label Jul 10, 2021
@Feiyang1 Feiyang1 added this to the v9 GA milestone Jul 10, 2021
@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2021

⚠️ No Changeset found

Latest commit: eeb4bb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.7" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@github-actions github-actions bot added the doc-changes PRs that affect docs label Jul 10, 2021
Copy link
Contributor

@jposuna jposuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Fireperf

@Feiyang1 Feiyang1 changed the title Update type names in v9 API [ WIP]Update type names in v9 API Jul 19, 2021
@Feiyang1 Feiyang1 changed the title [ WIP]Update type names in v9 API Update type names in v9 API Jul 22, 2021
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. We'll need to change a bunch of links from the guides and I can take that action as soon as reference docs are generated from this source. Thanks!

@Feiyang1 Feiyang1 merged commit 16958be into master Jul 27, 2021
@Feiyang1 Feiyang1 deleted the fei-typenames branch July 27, 2021 17:35
@firebase firebase locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
doc-changes PRs that affect docs v9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants