Skip to content

Fix more issues related to admin auth and appcheck. #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Conversation

jsdt
Copy link
Contributor

@jsdt jsdt commented Jul 12, 2021

This fixed two more problems with using admin credentials on node with appcheck enforced:

  1. We now pass the auth token to the transport constructor, and
  2. We set the header value to Bearer: <token>

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2021

🦋 Changeset detected

Latest commit: c4e2e90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2021

Binary Size Report

Affected SDKs

  • @firebase/app-check

    Type Base (aeab9ce) Head (7480cd4) Diff
    browser 22.5 kB 22.5 kB -7 B (-0.0%)
    esm2017 18.7 kB 18.7 kB -7 B (-0.0%)
    main 22.5 kB 22.5 kB -7 B (-0.0%)
    module 22.1 kB 22.1 kB -7 B (-0.0%)
  • @firebase/database

    Type Base (aeab9ce) Head (7480cd4) Diff
    browser 296 kB 296 kB +31 B (+0.0%)
    esm2017 265 kB 265 kB +33 B (+0.0%)
    main 299 kB 299 kB +31 B (+0.0%)
    module 296 kB 296 kB +31 B (+0.0%)
  • @firebase/database-compat

    Type Base (aeab9ce) Head (7480cd4) Diff
    browser 86.5 kB 86.6 kB +33 B (+0.0%)
    main 103 kB 103 kB +31 B (+0.0%)
    module 86.5 kB 86.6 kB +33 B (+0.0%)
  • @firebase/database-exp

    Type Base (aeab9ce) Head (7480cd4) Diff
    browser 246 kB 246 kB +33 B (+0.0%)
    main 278 kB 278 kB +31 B (+0.0%)
    module 246 kB 246 kB +33 B (+0.0%)
  • firebase

    Type Base (aeab9ce) Head (7480cd4) Diff
    firebase-app-check.js 22.8 kB 22.8 kB -4 B (-0.0%)
    firebase-database.js 187 kB 187 kB +21 B (+0.0%)
    firebase.js 893 kB 893 kB +17 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2021

Size Analysis Report

Affected Products

  • @firebase/app-check-exp

    • CustomProvider

      Size Table

      TypeBase (aeab9ce)Head (7480cd4)Diff
      size
      9.81 kB
      9.83 kB
      +23 B (+0.2%)
      size-with-ext-deps
      19.6 kB
      19.6 kB
      +25 B (+0.1%)
    • ReCaptchaV3Provider

      Size Table

      TypeBase (aeab9ce)Head (7480cd4)Diff
      size
      11.1 kB
      11.1 kB
      +24 B (+0.2%)
      size-with-ext-deps
      20.5 kB
      20.5 kB
      +25 B (+0.1%)
    • getToken

      Size Table

      TypeBase (aeab9ce)Head (7480cd4)Diff
      size
      9.52 kB
      9.54 kB
      +23 B (+0.2%)
      size-with-ext-deps
      18.9 kB
      18.9 kB
      +25 B (+0.1%)
    • initializeAppCheck

      Size Table

      TypeBase (aeab9ce)Head (7480cd4)Diff
      size
      9.93 kB
      9.96 kB
      +23 B (+0.2%)
      size-with-ext-deps
      19.5 kB
      19.5 kB
      +25 B (+0.1%)
    • onTokenChanged

      Size Table

      TypeBase (aeab9ce)Head (7480cd4)Diff
      size
      9.61 kB
      9.64 kB
      +23 B (+0.2%)
      size-with-ext-deps
      19.0 kB
      19.0 kB
      +25 B (+0.1%)
    • setTokenAutoRefreshEnabled

      Size Table

      TypeBase (aeab9ce)Head (7480cd4)Diff
      size
      9.65 kB
      9.67 kB
      +23 B (+0.2%)
      size-with-ext-deps
      19.0 kB
      19.0 kB
      +25 B (+0.1%)

@jsdt jsdt merged commit fb3e359 into master Jul 14, 2021
@jsdt jsdt deleted the jsdt/fix-authtoken branch July 14, 2021 19:15
@google-oss-bot google-oss-bot mentioned this pull request Jul 20, 2021
@firebase firebase locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants