Skip to content

[Auth] Add note above Cordova permissions in the demo sample-config.xml #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2021
Merged

[Auth] Add note above Cordova permissions in the demo sample-config.xml #5183

merged 1 commit into from
Jul 27, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 21, 2021

No description provided.

@sam-gc sam-gc requested a review from yuchenshi July 21, 2021 22:46
@sam-gc sam-gc requested a review from avolkovi as a code owner July 21, 2021 22:46
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2021

⚠️ No Changeset found

Latest commit: e4cf766

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (6ef484a) and head commit (cece8ab).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (6ef484a) and head commit (cece8ab).

@yuchenshi yuchenshi merged commit 3ac9272 into master Jul 27, 2021
@yuchenshi yuchenshi deleted the sam-gc/cordova-warning branch July 27, 2021 00:13
@firebase firebase locked and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi