Skip to content

Update import names #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Update import names #5212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfd10c0
update import names
Feiyang1 Jul 29, 2021
8140dbd
update name
Feiyang1 Jul 29, 2021
103e395
update names
Feiyang1 Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages-exp/installations-compat/src/installationsCompat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import { FirebaseInstallations as FirebaseInstallationsCompat } from '@firebase/installations-types';
import { FirebaseApp, _FirebaseService } from '@firebase/app-compat';
import {
FirebaseInstallations,
Installations,
deleteInstallations,
getId,
getToken,
Expand All @@ -28,11 +28,9 @@ import {
} from '@firebase/installations-exp';

export class InstallationsCompat
implements FirebaseInstallationsCompat, _FirebaseService {
constructor(
public app: FirebaseApp,
readonly _delegate: FirebaseInstallations
) {}
implements FirebaseInstallationsCompat, _FirebaseService
{
constructor(public app: FirebaseApp, readonly _delegate: Installations) {}

getId(): Promise<string> {
return getId(this._delegate);
Expand Down
4 changes: 2 additions & 2 deletions packages-exp/installations-compat/src/testing/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/

import { FirebaseApp } from '@firebase/app-compat';
import { FirebaseInstallations } from '@firebase/installations-exp';
import { Installations } from '@firebase/installations-exp';

const appName = 'testApp';
const apiKey = 'AIzaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaA';
Expand All @@ -41,7 +41,7 @@ export function getFakeApp(): FirebaseApp {
};
}

export function getFakeInstallations(): FirebaseInstallations {
export function getFakeInstallations(): Installations {
return {
app: getFakeApp(),
appConfig: {
Expand Down
4 changes: 2 additions & 2 deletions packages-exp/messaging-compat/src/messaging-compat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
_FirebaseService
} from '@firebase/app-compat';
import {
FirebaseMessaging,
Messaging,
MessagePayload,
deleteToken,
getToken,
Expand Down Expand Up @@ -89,7 +89,7 @@ function isSwSupported(): boolean {
}

export class MessagingCompatImpl implements MessagingCompat, _FirebaseService {
constructor(readonly app: AppCompat, readonly _delegate: FirebaseMessaging) {
constructor(readonly app: AppCompat, readonly _delegate: Messaging) {
this.app = app;
this._delegate = _delegate;
}
Expand Down
4 changes: 2 additions & 2 deletions packages-exp/messaging-compat/test/fakes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*/

import { FirebaseApp } from '@firebase/app-compat';
import { FirebaseMessaging } from '@firebase/messaging-exp';
import { Messaging } from '@firebase/messaging-exp';

export function getFakeApp(): FirebaseApp {
return {
Expand All @@ -36,6 +36,6 @@ export function getFakeApp(): FirebaseApp {
};
}

export function getFakeModularMessaging(): FirebaseMessaging {
export function getFakeModularMessaging(): Messaging {
return {};
}