Skip to content

[Auth] Fix popup opening location #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2021
Merged

[Auth] Fix popup opening location #5281

merged 2 commits into from
Aug 12, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Aug 11, 2021

Also fix/augment the tests which, embarrassingly, were actually testing for the wrong behavior...

Fixes #5275

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2021

⚠️ No Changeset found

Latest commit: e27a781

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (a69220b) and head commit (62ee189).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (a69220b) and head commit (62ee189).

@sam-gc sam-gc merged commit 888645e into master Aug 12, 2021
@sam-gc sam-gc deleted the sam-gc/window-position branch August 12, 2021 00:01
@firebase firebase locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v9 signInWithPopup opens in top left instead of centre screen
4 participants