Skip to content

Apply functional-style naming pattern to mutation.ts #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

The mutation file never followed the functional style naming convention we came up with during the firestore-exp migration. This PR changes the function names to follow the className+methodName pattern.

The mutation file never followed the functional style naming convention we came up with during the firestore-exp migration. This PR changes the function names to follow the className+methodName pattern.
@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2021

⚠️ No Changeset found

Latest commit: ce23cae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 12, 2021

Binary Size Report

Affected SDKs

No changes between base commit (888645e) and head commit (40184ff).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 12, 2021

Size Analysis Report

Affected Products

No changes between base commit (888645e) and head commit (1620a8b).

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Sep 2, 2021
@schmidt-sebastian schmidt-sebastian merged commit d77adb1 into master Sep 3, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/renames branch September 3, 2021 15:25
@firebase firebase locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants