Skip to content

Disable negative zero test on IndexedDB #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2021

🦋 Changeset detected

Latest commit: a9e643d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/firestore

    Make sure this was intentional.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 13, 2021

Binary Size Report

Affected SDKs

No changes between base commit (064e1ca) and head commit (c6352bf).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 13, 2021

Size Analysis Report

Affected Products

Diffs between base commit (064e1ca) and head commit (c6352bf) are too large (521,930 characters) to display.

Please check below links to see details from the original test log.

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this

@schmidt-sebastian schmidt-sebastian merged commit 4ec5344 into master Aug 16, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/negativezero branch August 16, 2021 16:32
@firebase firebase locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants