Skip to content

Disable long-polling test #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Disable long-polling test #5307

merged 2 commits into from
Aug 16, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2021

🦋 Changeset detected

Latest commit: 29a3db8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2021

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/firestore

    Make sure this was intentional.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 16, 2021

Binary Size Report

Affected SDKs

No changes between base commit (f0f474b) and head commit (e441ea9).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 16, 2021

Size Analysis Report

Affected Products

No changes between base commit (f0f474b) and head commit (e441ea9).

@schmidt-sebastian schmidt-sebastian merged commit 89f8665 into master Aug 16, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/testtimeout branch August 16, 2021 21:02
@firebase firebase locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants