Skip to content

Change functions to use messaging interop component #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

Modify functions service to use the new interop component messaging-internal.

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2021

⚠️ No Changeset found

Latest commit: a04ed30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (eca476a) and head commit (67fcb8b).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/functions-exp

    • connectFunctionsEmulator

      Size Table

      TypeBase (eca476a)Head (67fcb8b)Diff
      size
      2.36 kB
      2.39 kB
      +29 B (+1.2%)
      size-with-ext-deps
      7.09 kB
      7.13 kB
      +33 B (+0.5%)

      Dependency Table

      TypeBase (eca476a)Head (67fcb8b)Diff
      variables

      APP_CHECK_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      name
      version
      

      APP_CHECK_INTERNAL_NAME
      AUTH_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      MESSAGING_INTERNAL_NAME
      name
      version
      

      + AUTH_INTERNAL_NAME
      + MESSAGING_INTERNAL_NAME

    • getFunctions

      Size Table

      TypeBase (eca476a)Head (67fcb8b)Diff
      size
      2.38 kB
      2.41 kB
      +29 B (+1.2%)
      size-with-ext-deps
      8.42 kB
      8.45 kB
      +33 B (+0.4%)

      Dependency Table

      TypeBase (eca476a)Head (67fcb8b)Diff
      variables

      APP_CHECK_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      name
      version
      

      APP_CHECK_INTERNAL_NAME
      AUTH_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      MESSAGING_INTERNAL_NAME
      name
      version
      

      + AUTH_INTERNAL_NAME
      + MESSAGING_INTERNAL_NAME

    • httpsCallable

      Size Table

      TypeBase (eca476a)Head (67fcb8b)Diff
      size
      5.84 kB
      5.87 kB
      +29 B (+0.5%)
      size-with-ext-deps
      11.7 kB
      11.8 kB
      +33 B (+0.3%)

      Dependency Table

      TypeBase (eca476a)Head (67fcb8b)Diff
      variables

      APP_CHECK_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      LONG_TYPE
      UNSIGNED_LONG_TYPE
      errorCodeMap
      name
      version
      

      APP_CHECK_INTERNAL_NAME
      AUTH_INTERNAL_NAME
      DEFAULT_REGION
      FUNCTIONS_TYPE
      LONG_TYPE
      MESSAGING_INTERNAL_NAME
      UNSIGNED_LONG_TYPE
      errorCodeMap
      name
      version
      

      + AUTH_INTERNAL_NAME
      + MESSAGING_INTERNAL_NAME

@Feiyang1 Feiyang1 merged commit 7818176 into master Aug 21, 2021
@Feiyang1 Feiyang1 deleted the ch-fn-messaging branch August 21, 2021 00:11
hsubox76 added a commit that referenced this pull request Aug 23, 2021
* Change functions to use messaging interop

* prettier
@firebase firebase locked and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants